Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(storage): API for solved and unsolved configs #1692

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Oct 23, 2024

Extend D-Bus and HTTP APIs to get the solved storage config:

$ busctl --address unix:path=/run/agama/bus call org.opensuse.Agama.Storage1 /org/opensuse/Agama/Storage1 org.opensuse.Agama.Storage1 GetSolvedConfig
$ curl -H @headers.txt http://localhost/api/storage/solved_config

@coveralls
Copy link

coveralls commented Oct 23, 2024

Pull Request Test Coverage Report for Build 11517714636

Details

  • 67 of 77 (87.01%) changed or added relevant lines in 11 files are covered.
  • 44 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-17.8%) to 71.473%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rust/agama-lib/src/storage/client.rs 0 4 0.0%
rust/agama-server/src/storage/web.rs 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
service/lib/agama/storage/proposal.rb 2 98.2%
service/lib/agama/config.rb 4 94.94%
service/lib/agama/dbus/storage/manager.rb 38 78.33%
Totals Coverage Status
Change from base Build 11514248202: -17.8%
Covered Lines: 16937
Relevant Lines: 23697

💛 - Coveralls

@joseivanlopez joseivanlopez changed the title feature(storage): export solved and unsolved configs feature(storage): API for solved and unsolved configs Oct 24, 2024
@joseivanlopez joseivanlopez marked this pull request as ready for review October 24, 2024 14:18
- org.openSUSE.Agama.Storage1#GetSolvedConfig
@joseivanlopez joseivanlopez changed the base branch from master to storage-config-ui October 25, 2024 08:00
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseivanlopez joseivanlopez merged commit fd2433e into agama-project:storage-config-ui Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants