-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Human 1.19 deprecated since this does not follow the guidelines #819
Conversation
…ion. I don't think that code had ever been run, it was just not right.
…urrently only processes the model available in the repo, and does not compare with any older model version. The code is however prepared for comparing versions. Currently, it only processes 2 out of 40 chunks of data, this is to be changed when we want to run a full evaluation with 891 cell lines.
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
Added metabolite SMILES and Inchi Information
…tsv into MAR06416/7 and MAR06419/20
…move TMEM91 from the model
…AR03151 + MAR03153
…AR03158 + MAR03160
…AR03166 + MAR03885
…0,51,53,56,57,58,60,63,64,66
…d 2-OADH reactions and thiamine-to-lipoyl transfer for 2-OADH
…hiamine-dependent steps
Fix Duplicate BCKDH Reactions
Remove MAR03422
fix: standardize all names of exchange reactions
feat: add gene essentiality check using DepMap
Resolve Duplicate Phytanoyl-CoA Alpha-Oxidation Reactions
…linolenoyl_beta_ox_paths Merge Duplicate Mitochondrial Linoleic and Gamma-Linolenic Acid Beta-Oxidation Pathways
…to_gprs fix: GPRs for mitochondrial 2-enoyl-CoA hydratase reactions
Remove Tagatose-1,6-Bisphosphate
Fix Stereochemistry of Phytanic Acid Oxidation
…actions fix: modified unbalance reactions
Fix Mitochondrial Thiamine Transport Reactions
chore: update actions
Looking quickly in the changed files, most seem okay. However, I can already flag some changes that have to be verified one by one: there are lines deleted from the @feiranl you mentioned conflicts betwen feature branches. Were you able to track back to the original pull requests at the source of the confict? Another thing, could an updated gene essentiality table be provided, as in the PR for the previous release? |
Some IDs were recovered from the deprecated files. I looked into the conflict in yaml file, it should be these reactions: @mihai-sysbio I need to mention that this PR is not done following the guidelines of |
Of course! |
@feiranl the steps in the release guidelines have to be followed otherwise there will be consequences downstream, such as incorrect versions listed (hinted in the last bullet point). |
@mihai-sysbio Thanks! Totally understand. We are planning a new PR following the guidelines. This will be deleted later. But we need to wait until the RAVEN function is merged and the check is back to normal @edkerk May I know if there is any plan of when it will be merged? |
@feiranl RAVEN 2.9.2 was released yesterday |
Nice! thanks Ed. Will close this PR and reopen a new one to release the Human 1.19 @JHL-452b |
Main improvements in this PR:
ENSG00000084754 or ENSG00000072506
genes, as discussed in GPRs for Mitochondrial 3-Hydroxyacyl-CoA Oxidation Reactions #758ENSG00000105953 or ENSG00000181192
as GPRENSG00000248098 and ENSG00000083123
as GPRENSG00000248098 and ENSG00000083123
as GPRENSG00000248098 and ENSG00000083123
as GPRENSG00000248098 and ENSG00000083123
ENSG00000248098 and ENSG00000083123
as GPR and MAR20178 withENSG00000137992
as GPR.ENSG00000084754 or ENSG00000127884
(HADHA or ECHS1)MAM02746e, MAM02746c and MAM02746x
to "(3R)-phytanic acid" andMAM02747c and MAM02747x
to "(3R)-phytanoyl-CoA"ENSG00000125454
as GPR and "PMID:17035501" as references;ENSG00000125454
as GPR and "PMID:17035501" as references;ENSG00000125454
as GPR and "PMID:17035501" as references;I hereby confirm that I have:
develop
as a target branch