Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: standardize all names of exchange reactions #811

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Mar 13, 2024

Main improvements in this PR:

Contributing towards #181, names of exchange reactions are not ambiguous and can therefore directly be defined by the metabolite that they exchange. In 1.8.1, 469/1658 exchange reactions had no name.

Instead of only filling in the empty exchange reaction names, I redefined it for all exchange reactions, for consistency, but from the diff it also becomes clear that this fixes some previously unnecessarily complex names

Code:

[~,exchRxns] = getExchangeRxns(humanGEM);
[rxnNames, ~] = find(humanGEM.S(:,exchRxns));
rxnNames= humanGEM.metNames(rxnNames);
rxnNames= append('Exchange of ',rxnNames);
humanGEM.rxnNames(exchRxns) = rxnNames;

Example of non-empty reaction name that was changed:

ID Old name New name
MAR01986 Exchange of [ (2R, 3S, 4R, 5R)-5- (2, 4-Dioxo-1, 2, 3, 4-Tetrahydropyrimidin-1-Yl)-3, 4-Dihydroxyoxolan-2-Yl]Methyl {[ (3R, 4S, 5S, 6R)-3, 4, 5-Trihydroxy-6- (Hydroxymethyl)Oxan-2-Yl Phosphonato]Oxy}Phosphonate Exchange of UDP-glucose

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@mihai-sysbio mihai-sysbio self-requested a review March 14, 2024 06:49
Copy link
Member

@mihai-sysbio mihai-sysbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Just to note that some of the previous reaction names contained morphological metadata ("in hepatic vein", "in lumen", "in bile"). Perhaps some of this could be moved to the rxnNotes field.

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feiranl feiranl merged commit a0b15f6 into develop Mar 19, 2024
8 checks passed
@edkerk
Copy link
Member Author

edkerk commented Mar 19, 2024

Awesome!

Just to note that some of the previous reaction names contained morphological metadata ("in hepatic vein", "in lumen", "in bile"). Perhaps some of this could be moved to the rxnNotes field.

This might have been defined as such when first generating the model, but this information is never used to define tissue-specific functions (this is based on (f)tINIT), and not consistently done for all exchange reactions. Also, there are no duplicate exchange reactions: there are no seperate exchange reactions for e.g. "glucose exchange in hepatic vein" and "glucose exchange in myocytes" (and this also should not be the case!). I see therefore no purpose for retaining such legacy phrases in some reaction names.

@edkerk edkerk deleted the fix/exchangeRxnNames branch March 19, 2024 08:48
@JHL-452b JHL-452b mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants