-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Human 1.18 #735
Human 1.18 #735
Conversation
Remove MAR03940
style: merge "Heme biosynthesis" subsystem into "Porphyrin metabolism"
Fix MAR04665
Fix Mitochondrial Glutathione Transport
…y, and remove it from genes.tsv
Fix Oxoadipate Dehydrogenase
Updated essentiality evaluation using combined (
|
@haowang-bioinfo thank you for updating the essentiality results I was playing around yesterday with two different solvers on a knockout panel and I got different results, so I am wondering if the same solver has been used in all the evaluations since v1.12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've noticed there two commented-out metabolic tasks. I'm not really fond of having them in that state - I would propose that they are outright removed, or whatever underlying issue there is to be reported and ultimately resolved.
good question - for the listed analysis the same solver (gurobi 10) was used except for the results of v1.16, which was copied and I don't know what solver was specifically used |
Remove ACAD10
the PR message was just updated with #740 after its merging into v1.18, which should be enough and probably can move on to a new release? |
@mihai-sysbio, where are the tasks commented out? |
It's the Cellfie tasks here, specifically the last two commits. It makes sense for them to be commented out, but I still think it would be good to have an issue to at some point resolve this. |
This most likely refers to the changes made in #697, it was actually discussed but in an atypical way, not via an issue but under a PR (#696) |
Main improvements in this PR:
NA[c]
metabolite in Cellfile metabolic tasks #697)sanityCheck
to report reactions with identical metabolite IDsmetabolicatlas