Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/hexanoate #717

Merged
merged 8 commits into from
Oct 30, 2023
Merged

Fix/hexanoate #717

merged 8 commits into from
Oct 30, 2023

Conversation

pranasag
Copy link
Collaborator

@pranasag pranasag commented Oct 27, 2023

Main improvements in this PR:

This PR addresses #716 by removing the hexanoate MAM03684c species, and swapping hexanoic acid MAM02120c where applicable.

Changes done:

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@haowang-bioinfo
Copy link
Member

looks nice - please also merge annotation MAM03684 into MAM02120, such as the BiGG id

@pranasag
Copy link
Collaborator Author

Good spot - added the BiGG id to MAM02120. This was the only annotation missing (MAM02120 was way more complete than MAM03684.

Copy link
Member

@haowang-bioinfo haowang-bioinfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work

@haowang-bioinfo
Copy link
Member

if there is any evidence supporting an irreversible MAR10377?

@pranasag
Copy link
Collaborator Author

It involves hydrolyzing a high-energy bond, so the short answer is "thermodynamics". This traces back to the issues reported by Devlin Moyer and me (#527, #689), where [rightfully] setting reactions irreversible required additional fixes elsewhere

@haowang-bioinfo
Copy link
Member

haowang-bioinfo commented Oct 30, 2023

thanks for the clarification - may the GPR be updated with any ACOTs (#689), such as ACOT4 or ACOT6?

@pranasag
Copy link
Collaborator Author

For the peroxisomal reaction MAR10377, the best candidate is ACOT8 (ENSG00000101473), as ACOT4 and ACOT6 are known to be rather specific to certain acyl-CoAs. Alongside, mitochondrial reaction MAR10374 was also missing a GPR, I suggest ACOT9 (ENSG00000123130) since mitochondrial ACOTs with known specificity (ACOT2, ACOT7, and THEM5) are specific to very long-chain FAs.

@haowang-bioinfo
Copy link
Member

makes sense - please go ahead to implementation

@haowang-bioinfo haowang-bioinfo merged commit 589821a into develop Oct 30, 2023
8 checks passed
@haowang-bioinfo haowang-bioinfo deleted the fix/hexanoate branch October 30, 2023 09:59
@haowang-bioinfo haowang-bioinfo mentioned this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants