Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Representation of LIPT1 #714

Merged
merged 8 commits into from
Oct 29, 2023
Merged

Fix Representation of LIPT1 #714

merged 8 commits into from
Oct 29, 2023

Conversation

Devlin-Moyer
Copy link
Collaborator

@Devlin-Moyer Devlin-Moyer commented Oct 25, 2023 •
edited by haowang-bioinfo
Loading

Main improvements in this PR:

As proposed in #683:

  • Removes LIPT1 (ENSG00000144182) from the GPRs of MAR01088 and MAR01091
  • Removes MAR06398, MAR06399, and MAM02398c (lipoyl-AMP)
  • Creates new reaction MAR20168: MAM00209c -> MAM02393m, GPR: ENSG00000144182, references: PMID:29987032
  • Replaces MAM02393m with MAM00209c in MAR08433
  • Replaces MAM01701m with MAM00208c in MAR08434
  • Removes MAM02039c and MAM02039e from MAR11346
  • Removes MAM02039i and MAM02039m from MAR11361
  • Makes MAR11361 reversible
  • Removes MAR06408 and MAM01701c

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

haowang-bioinfo
haowang-bioinfo approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@haowang-bioinfo haowang-bioinfo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the implementation matchs with the claims in PR message

@haowang-bioinfo haowang-bioinfo merged commit 48eda9c into develop Oct 29, 2023
8 checks passed
@haowang-bioinfo haowang-bioinfo deleted the fix/LIPT1 branch October 29, 2023 21:12
@Devlin-Moyer Devlin-Moyer mentioned this pull request Oct 30, 2023
Closed
9 tasks
@haowang-bioinfo haowang-bioinfo mentioned this pull request Oct 30, 2023
Merged
3 tasks
@haowang-bioinfo haowang-bioinfo mentioned this pull request Dec 3, 2023
Merged
@edkerk edkerk mentioned this pull request Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haowang-bioinfo haowang-bioinfo haowang-bioinfo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Devlin-Moyer @haowang-bioinfo