-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/mito nuc trans #709
Fix/mito nuc trans #709
Conversation
…ed its references
…upported by evidence
MAR20138 and MAR20139 are same. Please remove one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM excep the duplicated rxn mentioned.
good job! minor thing: the new reaction |
MAR08301 already represented uniport of dTTP between the cytosol and mitochondria, so I didn't have to make a new reaction for it. I did have to make it reversible and associate it with SLC25A33, which is the second change listed in the PR message. |
wait, in that sense, this MAR20166 is duplicate to MAR08301, right? |
oh whoops that is right; MAR20166 shouldn't have been added cuz it is redundant with MAR08301. I can fix that in like an hour or two |
ok, then take away existing MAR20166 and turn MAR20167 into new MAR20166, also make them consistent with reactons.tsv please |
I wonder how this duplication pair (MAR20166 vs. MAR08301) was escaped from the memote test #672, any ideas? @mihai-sysbio |
Hmm that's interesting. Here is the official documentation of the function
Those two are indeed duplicated, so they should have been detected. I would have to run that test locally to confirm if it indeed did not work, or if it simply skipped over failing the check in an informative way. |
now this duplicate pair MAR08301:MAR20166 is captured by the updated yaml-validation action by #582 |
…uplicated MAR08301
Main improvements in this PR:
As proposed in #694:
ENSG00000171612
(name: SLC25A33) andENSG00000114120
(name: SLC25A36)MAR08301
reversible and change its GPR toENSG00000171612
MAR07823
,MAR07926
,MAR09019
andMAR04843
CTP [c] + CDP [m] <-> CTP [m] + CDP [c]
, GPR:ENSG00000114120
CTP [c] + CMP [m] <-> CTP [m] + CMP [c]
, GPR:ENSG00000114120
CTP [c] + dCTP [m] <-> CTP [m] + dCTP [c]
, GPR:ENSG00000114120
CTP [c] + dCDP [m] <-> CTP [m] + dCDP [c]
, GPR:ENSG00000114120
CTP [c] + dCMP [m] <-> CTP [m] + dCMP [c]
, GPR:ENSG00000114120
CTP [c] + GTP [m] <-> CTP [m] + GTP [c]
, GPR:ENSG00000114120
CTP [c] + GDP [m] <-> CTP [m] + GDP [c]
, GPR:ENSG00000114120
CTP [c] + GMP [m] <-> CTP [m] + GMP [c]
, GPR:ENSG00000114120
CTP [c] + dGTP [m] <-> CTP [m] + dGTP [c]
, GPR:ENSG00000114120
CTP [c] + dGDP [m] <-> CTP [m] + dGDP [c]
, GPR:ENSG00000114120
CTP [c] + dGMP [m] <-> CTP [m] + dGMP [c]
, GPR:ENSG00000114120
CTP [c] + ITP [m] <-> CTP [m] + ITP [c]
, GPR:ENSG00000114120
CTP [c] + IDP [m] <-> CTP [m] + IDP [c]
, GPR:ENSG00000114120
CTP [c] + IMP [m] <-> CTP [m] + IMP [c]
, GPR:ENSG00000114120
CTP [c] + UTP [m] <-> CTP [m] + UTP [c]
, GPR:ENSG00000114120 or ENSG00000171612
CTP [c] + UDP [m] <-> CTP [m] + UDP [c]
, GPR:ENSG00000114120
CTP [c] + UMP [m] <-> CTP [m] + UMP [c]
, GPR:ENSG00000114120
CTP [c] + dUTP [m] <-> CTP [m] + dUTP [c]
, GPR:ENSG00000114120
CTP [c] + dUDP [m] <-> CTP [m] + dUDP [c]
, GPR:ENSG00000114120
CTP [c] + dUMP [m] <-> CTP [m] + dUMP [c]
, GPR:ENSG00000114120
UTP [c] + CDP [m] <-> UTP [m] + CDP [c]
, GPR:ENSG00000171612
UTP [c] + dCTP [m] <-> UTP [m] + dCTP [c]
, GPR:ENSG00000171612
UTP [c] + dCDP [m] <-> UTP [m] + dCDP [c]
, GPR:ENSG00000171612
UTP [c] + GTP [m] <-> UTP [m] + GTP [c]
, GPR:ENSG00000171612
UTP [c] + GDP [m] <-> UTP [m] + GDP [c]
, GPR:ENSG00000171612
UTP [c] + dGTP [m] <-> UTP [m] + dGTP [c]
, GPR:ENSG00000171612
UTP [c] + dGDP [m] <-> UTP [m] + dGDP [c]
, GPR:ENSG00000171612
UTP [c] + ITP [m] <-> UTP [m] + ITP [c]
, GPR:ENSG00000171612
UTP [c] + dTTP [m] <-> UTP [m] + dTTP [c]
, GPR:ENSG00000171612
UTP [c] + dTDP [m] <-> UTP [m] + dTDP [c]
, GPR:ENSG00000171612
UTP [c] + UDP [m] <-> UTP [m] + UDP [c]
, GPR:ENSG00000171612
UTP [c] + dUTP [m] <-> UTP [m] + dUTP [c]
, GPR:ENSG00000171612
CTP [c] <-> CTP [m]
, GPR:ENSG00000114120 or ENSG00000171612
GTP [c] <-> GTP [m]
, GPR:ENSG00000114120 or ENSG00000171612
UTP [c] <-> UTP [m]
, GPR:ENSG00000114120 or ENSG00000171612
I hereby confirm that I have:
develop
as a target branch