feat: add basic memote tests #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again, to clarify - the |
haowang-bioinfo
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
the newly introduced memote test circumvent the pending error from typo in the metabolites key in yaml - this is great
another duplicate reaction check based on memote is also added in this PR, besides #582. In my view, it's okay have both
Merged
This was referenced Oct 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
This PR resolves #671 by introducing a basic MEMOTE tests in the
yaml-validationworkflow, and another new test that makes sure all reactions have at least one metabolite.I hereby confirm that I have:
fix/importExportCycleas a target branchNotes
This PR is not aimed directly at
develop, but at another branch where a bug was artificially introduced. The aim of this PR is then to capture this failure, then merge this PR. Finally, after reverting the commit introducing the bug, thefix/importExportCyclewill have valid content with improved workflows.