-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/fmn fmnh2 ids #712
Fix/fmn fmnh2 ids #712
Conversation
the charge state of FMN (MAM01828) should all be changed to -3, according to CHEBI annotation under pH=7.3 |
oh I just edited the rows for Also if we change the charges on any of the FMN metabolites, we're going to have to edit all the reactions they participate in to make sure they're still charge- and mass-balanced |
yes please, these ids won't be reused anyway
you are right, the related reactions should be balanced. Please double check, maybe they already are |
…bolites and added old IDs to metRetired column of metabolites.tsv
I haven't looked at all of these super carefully, but I'm pretty sure every single one would have to be changed to keep them charge-balanced after changing the charges on the FMN metabolites from -2 to -3
|
hmm it looks like all of the reactions that involve |
oh it occurs to me that part of the problem with the currently-imbalanced reactions in [i] and [r] is that they have (neutral) fatty acids as reactants and produce the conjugate bases + protons as products, but the conjugate bases incorrectly have charges of 0. While changing all of those charges to -1 would I think be more realistic, we'd have to see if all of the other reactions each of those metabolites participates in would also have to be adjusted, and I don't know how many more rounds of that would be necessary |
right, maybe okay to merge and resolve the balancing issue another time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now the issues mentioned in #711 have been addressed
Main improvements in this PR:
As proposed in #711:
MAM20020r
toMAM01828r
to match FMN metabolites in other compartmentsMAM20023i
toMAM01828i
to match FMN metabolites in other compartmentsMAM20022i
toMAM20019i
to match FMNH2 metabolites in other compartmentsMAM01828r
andMAM01828i
toC17H19N4O9P
MAM01828r
andMAM01828i
with KEGG IDC00061
MAM20019r
andMAM20019i
with KEGG IDC01847
I hereby confirm that I have:
develop
as a target branch