Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add new reactions annotated for genes related to Glycolysis pathway #535

Merged
merged 7 commits into from
Apr 18, 2023
Merged

feat: Add new reactions annotated for genes related to Glycolysis pathway #535

merged 7 commits into from
Apr 18, 2023

Conversation

feiranl
Copy link
Collaborator

@feiranl feiranl commented Apr 15, 2023

Main improvements in this PR:

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@feiranl feiranl mentioned this pull request Apr 15, 2023
Closed
3 tasks
haowang-bioinfo
haowang-bioinfo reviewed Apr 16, 2023
View reviewed changes
code/modelCuration/GlycolysisCuration.m Outdated
structure.metHMDBID = [structure.metHMDBID;MetStruct.BiGGID(idx,1)];
structure.metChEBIID = [structure.metChEBIID;MetStruct.CHEBI(idx,1)];
structure.metPubChemID = [structure.metPubChemID;MetStruct.BiGGID(idx,1)];
structure.metLipidMapsID = [structure.metLipidMapsID;MetStruct.CHEBI(idx,1)];
Copy link
Member

@haowang-bioinfo haowang-bioinfo Apr 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the line 49 probably should be modified, now ChEBI ids were also updated to the column of Lipidmap ids

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying this. Changed in the latest commit.

@haowang-bioinfo
Copy link
Member

very good progress!

haowang-bioinfo
haowang-bioinfo approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@haowang-bioinfo haowang-bioinfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@haowang-bioinfo haowang-bioinfo merged commit 885c9a6 into develop Apr 18, 2023
@haowang-bioinfo haowang-bioinfo deleted the addGlyRxn branch April 18, 2023 06:29
@haowang-bioinfo haowang-bioinfo mentioned this pull request Apr 28, 2023
Closed
2 tasks
@haowang-bioinfo haowang-bioinfo mentioned this pull request May 7, 2023
Merged
@feiranl feiranl mentioned this pull request May 17, 2023
Closed
9 tasks
@haowang-bioinfo haowang-bioinfo mentioned this pull request Oct 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haowang-bioinfo haowang-bioinfo haowang-bioinfo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feiranl @haowang-bioinfo