Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Duplicate Glycerol-3-Phosphate Dehydrogenase Reactions #710

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

Devlin-Moyer
Copy link
Collaborator

Main improvements in this PR:

As proposed at the end of the discussion in #599:

  • Removes MAR00478 because there's no evidence that GPD1 or GPD1L can use NADP(H) in addition to NAD(H)
  • Removes MAR00482 because GPD2 is definitely localized to the inner mitochondrial membrane, so it should use FAD(H2) [m] and not [c]

Also while not explicitly proposed in #599:

  • Merges annotations for MAR00478 in reactions.tsv and its associated reference with those for MAR00479, since they're nearly identical reactions
  • Merges annotations for MAR00482 in reactions.tsv into those for MAR01169, since, again, they're nearly identical reactions

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haowang-bioinfo haowang-bioinfo merged commit baa778e into develop Oct 18, 2023
8 checks passed
@haowang-bioinfo haowang-bioinfo deleted the fix/duplicate_glyc3P_DH_rxns branch October 18, 2023 20:00
@haowang-bioinfo haowang-bioinfo mentioned this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants