Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Duplicate BCKDH Reactions #743

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Fix Duplicate BCKDH Reactions #743

merged 1 commit into from
Dec 10, 2023

Conversation

Devlin-Moyer
Copy link
Collaborator

Main improvements in this PR:

As proposed in #741:

  • Removes MAR03748 for being a duplicate of MAR06416 + MAR06417 + MAR06409
  • Merges annotations for MAR03748 in reactions.tsv into those for MAR06416 and MAR06417
  • Removes MAR03780 for being a duplicate of MAR06419 + MAR06420 + MAR06409
  • Merges annotations for MAR03780 in reactions.tsv into those for MAR06419 and MAR06420

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

haowang-bioinfo
haowang-bioinfo approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@haowang-bioinfo haowang-bioinfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Devlin-Moyer Devlin-Moyer changed the title fix: remove MAR03748 and MAR03780 and merge annotations in reactions.… Fix Duplicate BCKDH Reactions Dec 7, 2023
@Devlin-Moyer Devlin-Moyer mentioned this pull request Dec 8, 2023
Merged
3 tasks
@haowang-bioinfo haowang-bioinfo merged commit 783c84e into develop Dec 10, 2023
8 checks passed
@haowang-bioinfo haowang-bioinfo deleted the fix/BCKDH_duplicates branch December 10, 2023 11:02
@haowang-bioinfo haowang-bioinfo mentioned this pull request Dec 10, 2023
Closed
2 tasks
@JHL-452b JHL-452b mentioned this pull request May 8, 2024
Closed
3 tasks
@JHL-452b JHL-452b mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haowang-bioinfo haowang-bioinfo haowang-bioinfo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Devlin-Moyer @haowang-bioinfo