Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MAR00965 and Fix GPR of MAR00970 #794

Merged
merged 5 commits into from
Jan 8, 2024

Conversation

Devlin-Moyer
Copy link
Collaborator

Main improvements in this PR:

As proposed in #748, removes MAR00965 and fixes the GPR of MAR00970

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@feiranl feiranl self-requested a review December 31, 2023 07:28
@feiranl
Copy link
Collaborator

feiranl commented Dec 31, 2023

(ENSG00000115361 or ENSG00000177646) and (ENSG00000167969 or ENSG00000198721) and ENSG00000104823 and ENSG00000104325 and ENSG00000084754 and ENSG00000138029 is not a standard GPR rule, it should be (ENSG00000115361 and ENSG00000167969 and ENSG00000104823 and ENSG00000104325 and ENSG00000084754 and ENSG00000138029) or (ENSG00000115361 and ENSG00000198721 and ENSG00000104823 and ENSG00000104325 and ENSG00000084754 and ENSG00000138029) or (ENSG00000177646 and ENSG00000167969 and ENSG00000104823 and ENSG00000104325 and ENSG00000084754 and ENSG00000138029) or (ENSG00000177646 and ENSG00000198721 and ENSG00000104823 and ENSG00000104325 and ENSG00000084754 and ENSG0000013802)

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants