-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZERO Hydra Failures 21.05 #122042
Comments
This issue has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nixos-21-05-zero-hydra-failures/12954/1 |
This comment has been minimized.
This comment has been minimized.
just figured that it might make sense to pin this for easier discoverability :) |
This comment has been minimized.
This comment has been minimized.
@NixOS/release-engineers would you all be okay with me changing the wording to have you all pinged for each ZHF PR. I don't want to overload individuals |
ZHF NixOS#122042 Failing Hydra build: https://hydra.nixos.org/build/142625836
ZHF #122042 Failing Hydra build: https://hydra.nixos.org/build/143815905 Currently the diff-check for `.mp3`-files is failing. The only reason for that is that right now is that there are too spaces too much on the last line[1]. [1] https://salsa.debian.org/reproducible-builds/diffoscope/-/blob/175/tests/data/mp3_expected_diff (cherry picked from commit ea55d23)
Fixes can always be backported. Going to close this for now, as the release has already happened. Thank you everyone for your hard work! :) |
This issue has been mentioned on NixOS Discourse. There might be relevant details there: |
Update
I have updated the steps to reflect the new backport workflow. Please review, if not familiar with the process.
Mission
Every time we branch off a release we stabilize the release branch.
Our goal here is to get as little as possible jobs failing on the trunk/master jobsets.
I'd like to heighten, while it's great to focus on zero as our goal, it's essentially to
have all deliverables that worked in the previous release work here also.
NOTE: ZHF for this release will be significantly different from past ZHFs, with the
changes included in RFC 85.
Most significantly, branch off will occur on May 21st; prior to that date, ZHF will be conducted
on master; after that date, ZHF will be conducted on the release channel using a backport
workflow similar to previous ZHFs.
Jobsets
trunk Jobset (includes linux, darwin, and aarch64-linux builds)
nixos/combined Jobset (includes many nixos tests)
How many failing jobs are there?
At the opening of this issue we have the main
x86_64-linux
jobset at 643 failing jobs,x86_64-darwin
at 1251, andaarch64-linux
at 1067.Thanks to nix-review-tools we know which dependencies are causing the most jobs to fail in these individual jobsets:
Previous releases first evals
19.09 had 1654 failing jobs
20.03 had 1204 failing jobs
20.09 had 1153 failing jobs
21.05 had 789 failing jobs
So we're actually getting better at maintaining a more stable "unstable" channel.
How to help (textual)
Select an evaluation of the trunk jobset
Find a failed job ❌️ , you can use the filter field to scope packages to your platform, or search for packages that are relevant to you.
Search to see if a PR is not already open for the package. It there is one, please help review it.
If there is no open PR, troubleshoot why it's failing and fix it.
Create a Pull Request with the fix targeting master, wait for it to be merged.
If your PR causes around 500+ rebuilds, it's preferred to target
staging
to avoid compute and storage churn.After your PR to master or staging has occured. Please follow backporting steps and target the
release-21.05
branch if the original PR landed inmaster
orstaging-21.05
if the PR landed instaging
. Be sure to dogit cherry-pick -x <rev>
on the commits that landed in unstable. I created a video covering the backport process.Always reference this issue in the body of your PR:
Please ping @NixOS/nixos-release-managers on the PR.
If you're unable to because you're not a member of the NixOS org please ping @jonringer
How can I easily check packages that I maintain?
You're able to check failing packages that you maintain by running:
New to nixpkgs?
I created some videos to help get people started with nixpkgs:
Also be sure to check out other resources at: https://github.com/nix-community/awesome-nix
Packages that don't get fixed
The remaining packages will be marked as broken before the release (on the failing platforms).
You can do this like:
Closing
This is a great way to help NixOS, and it is a great time for new contributors to start their nixpkgs adventure. 🥳
cc @NixOS/nixpkgs-committers @NixOS/nixpkgs-maintainers
Related Issues
The text was updated successfully, but these errors were encountered: