Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21.05] python3Packages.scikit-learn: unbreak darwin #124414

Merged
merged 2 commits into from
May 26, 2021
Merged

[21.05] python3Packages.scikit-learn: unbreak darwin #124414

merged 2 commits into from
May 26, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 25, 2021 •
edited
Loading

Motivation for this change

Backport of #124255

ZHF #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

nbren12 and others added 2 commits May 25, 2021 19:57
@nbren12 @risicle
python3Packages.scikitlearn: disable flaky tests
6638d62 
* Disable all tests of the NuSVC estimator that use memmap'd data
* build in serial on darwin

Resolves NixOS#121988

(cherry picked from commit cb2891b)
@DavHau @risicle
scikit-learn: disable some tests for darwin
52030b6 
(cherry picked from commit 4af4723)
@risicle risicle requested review from FRidh and jonringer as code owners May 25, 2021 19:00
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 25, 2021
@risicle risicle mentioned this pull request May 25, 2021
Closed
9 tasks
@ofborg ofborg bot requested a review from DavHau May 25, 2021 19:10
@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.scikit-learn

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 25, 2021 •
edited
Loading

Result of nixpkgs-review pr 124414 at 52030b6 run on aarch64-linux 1

23 packages marked as broken and skipped:
  • python38Packages.cnvkit
  • python38Packages.dask-ml
  • python38Packages.dask-xgboost
  • python38Packages.dftfit
  • python38Packages.ignite
  • python38Packages.mlxtend
  • python38Packages.optuna
  • python38Packages.osmnx
  • python38Packages.pygbm
  • python38Packages.shap
  • ...
3 packages failed to build:
22 packages skipped due to time constraints:
  • python38Packages.batchgenerators
  • python38Packages.dask-glm
  • python38Packages.graspologic
  • python38Packages.hyppo
  • python38Packages.nilearn
  • python38Packages.pytorch-metric-learning
  • python38Packages.qiskit
  • python38Packages.qiskit-aqua
  • python38Packages.qiskit-ignis
  • python38Packages.scikit-optimize
  • ...
28 packages built successfully:
  • python38Packages.bayesian-optimization
  • python38Packages.hdbscan
  • python38Packages.hmmlearn
  • python38Packages.imbalanced-learn
  • python38Packages.kmapper
  • python38Packages.librosa
  • python38Packages.lightgbm
  • python38Packages.mlrose
  • python38Packages.persim
  • python38Packages.ppscore
  • python38Packages.pynndescent
  • python38Packages.ripser
  • python38Packages.scikitlearn (python38Packages.scikit-learn)
  • python38Packages.seqeval
  • python38Packages.word2vec
  • python39Packages.batchgenerators
  • python39Packages.bayesian-optimization
  • python39Packages.hmmlearn
  • python39Packages.imbalanced-learn
  • python39Packages.kmapper
  • python39Packages.lightgbm
  • python39Packages.mlrose
  • python39Packages.persim
  • python39Packages.ppscore
  • python39Packages.ripser
  • python39Packages.scikitlearn (python39Packages.scikit-learn)
  • python39Packages.seqeval
  • python39Packages.word2vec

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 124414 at 52030b6 run on x86_64-linux 1

16 packages marked as broken and skipped:
  • python38Packages.dask-xgboost
  • python38Packages.dftfit
  • python38Packages.mlxtend
  • python38Packages.optuna
  • python38Packages.osmnx
  • python38Packages.pygbm
  • python38Packages.shap
  • python38Packages.sklearn-deap
  • python38Packages.skorch
  • python38Packages.textacy
  • ...
2 packages failed to build:
27 packages skipped due to time constraints:
  • python38Packages.cnvkit
  • python38Packages.dask-glm
  • python38Packages.dask-ml
  • python38Packages.graspologic
  • python38Packages.hdbscan
  • python38Packages.hyppo
  • python38Packages.ignite
  • python38Packages.nilearn
  • python38Packages.pytorch-metric-learning
  • python38Packages.qiskit
  • ...
32 packages built successfully:
  • python38Packages.batchgenerators
  • python38Packages.bayesian-optimization
  • python38Packages.hmmlearn
  • python38Packages.imbalanced-learn
  • python38Packages.kmapper
  • python38Packages.librosa
  • python38Packages.lightgbm
  • python38Packages.mlrose
  • python38Packages.persim
  • python38Packages.ppscore
  • python38Packages.pynndescent
  • python38Packages.ripser
  • python38Packages.scikit-bio
  • python38Packages.scikitlearn (python38Packages.scikit-learn)
  • python38Packages.seqeval
  • python38Packages.vowpalwabbit
  • python38Packages.word2vec
  • python39Packages.batchgenerators
  • python39Packages.bayesian-optimization
  • python39Packages.imbalanced-learn
  • python39Packages.kmapper
  • python39Packages.lightgbm
  • python39Packages.mlrose
  • python39Packages.persim
  • python39Packages.ppscore
  • python39Packages.ripser
  • python39Packages.scikit-bio
  • python39Packages.scikitlearn (python39Packages.scikit-learn)
  • python39Packages.seqeval
  • python39Packages.vowpalwabbit
  • python39Packages.word2vec
  • python39Packages.xgboost

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@jonringer jonringer merged commit 97fc742 into NixOS:release-21.05 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@DavHau DavHau Awaiting requested review from DavHau

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@risicle @jonringer @r-rmcgibbo @nbren12 @DavHau