Skip to content

Commit

Permalink
python3Packages.scikitlearn: disable flaky tests
Browse files Browse the repository at this point in the history
* Disable all tests of the NuSVC estimator that use memmap'd data
* build in serial on darwin

Resolves NixOS#121988
  • Loading branch information
nbren12 committed May 23, 2021
1 parent 594fbfe commit cb2891b
Showing 1 changed file with 16 additions and 3 deletions.
19 changes: 16 additions & 3 deletions pkgs/development/python-modules/scikit-learn/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,23 @@ buildPythonPackage rec {

doCheck = !stdenv.isAarch64;

# Skip test_feature_importance_regression - does web fetch
disabledTests = [ "test_feature_importance_regression" ];
disabledTests = [
# Skip test_feature_importance_regression - does web fetch
"test_feature_importance_regression"
];

pytestFlagsArray = [ "-n" "$NIX_BUILD_CORES" "--pyargs" "sklearn" ];
pytestFlagsArray = [
# verbose build outputs needed to debug hard-to-reproduce hydra failures
"-v"
"--pyargs" "sklearn"
# NuSVC memmap tests causes segmentation faults in certain environments
# (e.g. Hydra Darwin machines) related to a long-standing joblib issue
# (https://github.com/joblib/joblib/issues/563). See also:
# https://github.com/scikit-learn/scikit-learn/issues/17582
"-k 'not (NuSVC and memmap)'"
] ++ lib.optionals (!stdenv.isDarwin) [
"-n" "$NIX_BUILD_CORES"
];

preCheck = ''
cd $TMPDIR
Expand Down

0 comments on commit cb2891b

Please sign in to comment.