Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdfview: Fix build #122052

Merged
merged 2 commits into from
May 7, 2021
Merged

hdfview: Fix build #122052

merged 2 commits into from
May 7, 2021

Conversation

SFrijters
Copy link
Member

@SFrijters SFrijters commented May 7, 2021 •
edited
Loading

Motivation for this change

ZHF: #122042

Looks like hdfview is not compatible with HDF5 1.12.x so it needs the 1.10.x version.
However, it also needs Java, so I've (re-?)added that option to the 1.10.x version.

@NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 7, 2021
jonringer
jonringer approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/122052

1 package built:
hdfview

@jonringer jonringer merged commit c47c00e into NixOS:master May 7, 2021
@SFrijters SFrijters deleted the hdfview branch May 16, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SFrijters @jonringer