Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pycm: add two necessary dependencies #122062

Merged
merged 1 commit into from
May 7, 2021
Merged

pycm: add two necessary dependencies #122062

merged 1 commit into from
May 7, 2021

Conversation

evalexpr
Copy link
Member

@evalexpr evalexpr commented May 7, 2021 •
edited
Loading

Motivation for this change

ZHF: #122042

Adds two dependencies necessary to build/test. Hydra failure: https://hydra.nixos.org/build/142057098/nixlog/2

Note from pycm README:

warning Plotting capability requires Matplotlib (>= 3.0.0) or Seaborn (>= 0.9.1)

CC @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evalexpr evalexpr requested review from FRidh and jonringer as code owners May 7, 2021 17:43
@evalexpr evalexpr changed the title add two necessary dependencies pycm: add two necessary dependencies May 7, 2021
evalexpr
evalexpr commented May 7, 2021
View reviewed changes
pkgs/development/python-modules/pycm/default.nix Outdated
@@ -20,6 +20,8 @@ buildPythonPackage rec {
'';

checkInputs = [ pytest ];

buildInputs = [ matplotlib seaborn ];
Copy link
Member Author

@evalexpr evalexpr May 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be propagated? these are technically runtime deps I suppose if you try to call cm.plot() without either of these libraries you'll get an error from pycm telling you to pip install matplotlib

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python packages should be propagated, yes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed.

@ofborg ofborg bot requested a review from bcdarwin May 7, 2021 18:05
jonringer
jonringer approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 122062 run on x86_64-linux 1

2 packages built:
  • python38Packages.pycm
  • python39Packages.pycm

@jonringer jonringer merged commit 32a245b into NixOS:master May 7, 2021
@evalexpr evalexpr deleted the zhf-fix-pycm branch May 7, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evalexpr @jonringer