Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport jupyterlab darwin fixes #124565

Merged
merged 3 commits into from
May 27, 2021
Merged

backport jupyterlab darwin fixes #124565

merged 3 commits into from
May 27, 2021

Conversation

nbren12
Copy link
Contributor

@nbren12 nbren12 commented May 27, 2021

Motivation for this change

Backport changes from #124101

ZHF: #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 27, 2021
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: policy discussion 6.topic: python 6.topic: qt/kde 6.topic: stdenv Standard environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels May 27, 2021
@nbren12 nbren12 changed the base branch from master to release-21.05 May 27, 2021 02:32
@github-actions github-actions bot removed 6.topic: policy discussion 8.has: changelog 6.topic: stdenv Standard environment 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: qt/kde 8.has: documentation This PR adds or changes documentation labels May 27, 2021
@nbren12 nbren12 force-pushed the jupyterlab-backport branch from f7a93c3 to c8a75cc Compare May 27, 2021 02:33
@ofborg ofborg bot requested review from costrouc and elohmeier May 27, 2021 02:43
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 27, 2021
@SuperSandro2000 SuperSandro2000 merged commit ff00b8c into NixOS:release-21.05 May 27, 2021
@nbren12 nbren12 deleted the jupyterlab-backport branch May 27, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@infinisil infinisil Awaiting requested review from infinisil

@jonringer jonringer Awaiting requested review from jonringer

@Mic92 Mic92 Awaiting requested review from Mic92

@mmahut mmahut Awaiting requested review from mmahut

@nbp nbp Awaiting requested review from nbp

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@ryantm ryantm Awaiting requested review from ryantm

@teto teto Awaiting requested review from teto

@ttuegel ttuegel Awaiting requested review from ttuegel

@zowoq zowoq Awaiting requested review from zowoq

@costrouc costrouc Awaiting requested review from costrouc

@elohmeier elohmeier Awaiting requested review from elohmeier

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbren12 @SuperSandro2000