Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.fancontrol: fix test; clean up module #122074

Merged
merged 2 commits into from
May 7, 2021
Merged

nixosTests.fancontrol: fix test; clean up module #122074

merged 2 commits into from
May 7, 2021

Conversation

evils
Copy link
Member

@evils evils commented May 7, 2021

Motivation for this change

ZHF: #122042
@NixOS/nixos-release-managers

Things done

fix test by not waiting for the service (the service is not expected to keep running, can't do a fancontrol config for a VM?)
clean up module (added lm_sensors group and fancontrol user, removed default config (a config is required, no default can be guessed))
added myself as maintainer to both the test and the module

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

evils added 2 commits May 7, 2021 20:01
@evils
nixosTests.fancontrol: fix test
2f043d9 
and set myself (module author) as maintainer
@evils
nixos/fancontrol: clean up module
14070c5 
set a group and user for the service
remove default null config
  it's required, now it throws an error pointing to the option

set myself (module author) as maintainer
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 7, 2021
jonringer
jonringer approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[nix-shell:~/.cache/nixpkgs-review/pr-122074]$ nix-build ./nixpkgs/ -A nixosTests.fancontrol
/nix/store/j99i7i1by3bxv1nlhhd02ndgyc5k8v4y-vm-test-run-fancontrol

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 7, 2021
@jonringer jonringer merged commit 5ae9027 into NixOS:master May 7, 2021
@mlvzk
Copy link
Member

mlvzk commented May 17, 2021 •
edited
Loading

This new User and Group setting broke my configuration. The fancontrol service was failing with Error: file hwmon3/pwm1 doesn't exist

@evils
Copy link
Member Author

evils commented May 17, 2021

i get similar failures once in a while
especially on kernel changes
i suspect there's something making the available end-points (hwmon3/pwm1 in this case) not very stable
so far i've been able to get around it by either trying nixos-rebuild again, or going through pwmconfig again

i don't think it's due to the user & group stuff
but it is an issue i've encountered sporadically

@jonringer
Copy link
Contributor

could be that there should be another users.users.fancontrol and related group entry. Just to ensure that those uid and gid get generated.

@evils
Copy link
Member Author

evils commented May 17, 2021

hmm, turns out i was just running with a broken fancontrol service...
i'm investigating further
currently i suspect it's lacking access to the /sys/devices endpoints it uses to control stuff

shudders at the discovery this is just bash scripts

@evils evils mentioned this pull request May 17, 2021
Merged
10 tasks
@evils
Copy link
Member Author

evils commented May 17, 2021

@mlvzk i've opened #123324 to revert that breaking change, thanks for pointing it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evils @mlvzk @jonringer