Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinball: fix #124441

Merged
merged 1 commit into from
May 26, 2021
Merged

pinball: fix #124441

merged 1 commit into from
May 26, 2021

Conversation

hrhino
Copy link
Contributor

@hrhino hrhino commented May 26, 2021 •
edited
Loading

There was an override of autoconfHook to use automake 1.15.x; I'm not sure what changed since this package was added but it explicitly needs 1.16.1 or greater for the submodule libltdl.

Anyhow, just remove the override.

Motivation for this change

ZHF: #122042 (or at least to keep master a bit more stable); ping @jonringer if he wants this merged for that

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.
  • Also tested manually to the extent possible...

@hrhino
pinball: fix
3e4aeea 
There was an override of autoconfHook to use automake 1.15.x; I'm not
sure what changed since this package was added but it explicitly needs
1.16.1 or greater for the submodule libltdl.

Anyhow, just remove the override.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 26, 2021
@SuperSandro2000 SuperSandro2000 merged commit 47254fd into NixOS:master May 26, 2021
@hrhino hrhino mentioned this pull request May 26, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hrhino @SuperSandro2000