-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.Nikola: disable failing test #124320
Conversation
@ofborg build python3.pkgs.Nikola |
Pywemo also has issues with the libxml2 2.9.12 upgrade. #124165 |
That issue is what made me aware of the libxml2 bump being the culprit. |
Should we be running round disabling loads of tests rather than fixing the apparently buggy libxml2 2.9.12? |
Also testing on darwin - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll need to remove broken = stdenv.isDarwin;
from meta
I tried that but removed the commit doing so again. As @risicle mentioned watchdog doesn't build on Darwin so there's no point in trying.
Is that still an option for 21.05? |
I don't imagine we can ship 21.05 with the glaring libxml2 bug. |
The patch is in both of the staging-next channels, we can also target that base branch |
Motivation for this change
ZHF: #122042
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)cc @NixOS/nixos-release-managers
@ofborg build python3.pkgs.Nikola