Version v10.29.0 RC #18488
Merged
Version v10.29.0 RC #18488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8007) * Fix #17974 / add REQUEST_DISABLED event * RPCMiddleware: add eth_sign REQUEST_DISABLED test * don't call Signature Request for disabled eth_sign * clean: alphabetize * clean: rn isDisabledRequest -> isDisabledRPCMethod * fix test * rpc middeware: add eth_sign comment * fix eth_sign events and re-add Signature Request * send 'Signature Failed' for disabled eth_sigh
…18129) * Revert "Moved subscribe and filter into network controller (#16693)" This reverts commit 6f6984f. That commit was an RPC middleware refactor intended to move the subscribe and filter middleware into the network controller, to simplify the process of sharing this middleware between clients. This refactor resulted in `eth_subscribe` notifications being sent on the wrong connections, causing the UI to break in some cases (the UI `provider` connection does not support notifications). This happened because the `setupProviderEngine` function runs per-connection, whereas the engine setup inside the network controller is global. The global network client cannot support notifications because it has no way to route them; they'll need to stay in the per-connection provider engine. Closes #17467 * Add e2e test An e2e test has been added that confirms subscriptions are only broadcast to the site that registered them. This test fails on `develop`.
* waitForSelector and pasteIntoField used now
* Updated confirm-page-container-summary.component.js * Updated snap-insight.js * Updated confirmation-warning-modal.js * Updated create-new-vault.js * Fixing import errors, linting errors and adding a story * Updating storybook path * Updating snapshot --------- Co-authored-by: georgewrmarshall <[email protected]>
* MMI adds the Jwt dropdown * MMI prettier * review fixes * MMI added stories file
* MMI adds the note-to-trader component * MMI adds colors vars * MMI added component folder * MMI adds fireEvent * adds Box * review fixes * adds story * lint fix * prettier fix * prettier fix --------- Co-authored-by: Albert Olivé <[email protected]>
* added allowlisted protocol snap's derivation paths * added missing path
* add e2e test for onboarding flow * Add method to test if we create a new wallet * fix code * editng code * Add test if import wrong SRP * fix test * add test where we chack if user select diffrent type of SRP * update test for checking if user select different SRP * update code * add test for if user enter wrong password in confirm password field * add two test to verify if user is on correct page after import wallet * update cod * lint fix * fix code to test pass * fix code * improve code * change completeCreateNewWalletOnboardingFlow function parameters and update code * delete unnecessary wait --------- Co-authored-by: dzfjz <[email protected]> Co-authored-by: dzfjz <[email protected]>
…state (#18127) * make network-controller methods overwrite rather than merge provider state
If you're thinking about converting a file to TypeScript, you might want to know what files import that file and what files it imports. This commit makes it so that if you click on a box in the visualization, it will draw lines between that box and the other boxes which represent its dependents and dependencies. Co-authored-by: legobeat <[email protected]>
* add fixture * update test * update test * wait for ETH balance
* allow SnapController to call `ApprovalController:updateRequestState` action * combine popups * show only autorship pill on result * lint * update `[email protected]` and regen policies * dedupe deps and fix fencing * fix update button text * fix fencing * Update a bunch of e2es * address requested changes * update policy * bump key-tree * fix lint * Update RPC E2E * fix locales * Remove wrong instance of window handle polling * design changes and address pr comments * remove unused imports * fix lint * fix fencing * remove unused locales * fence things * re-add redirection * bump test-snaps version * Fix update e2e * fix redirecting logic and address requested changes * force update metamask state on approved * move force update --------- Co-authored-by: Frederik Bolding <[email protected]>
* security: patch request for CVE-2023-28155 GHSA-p8p7-x288-28g6 Ported from request/request#3444 * add iyarc exclusion
* Updating AvatarBase to use Text component instead of Box and adding font size logic based on avatar size * Updating snaps
…disable domain binding (#18200) * siwe: re-enable warning UI for mismatched domains - unblocks mismatched domain support - we may re-add error handling here #18184 - reverts logic from #16616 * siwe: fix mismatch domain warning msg UI * lint: rm whitespace EOL * siwe: rm unit test * lint: fix whitespace * Revert "siwe: rm unit test" This reverts commit c80a4a2. --------- Co-authored-by: legobeat <[email protected]>
* Using ganache requests to get balances * Replace getBalance getAccounts with ganache funcs * Add secondary ganache server to testsuite
* Add tooltips to show info about a permission * Make Tooltip component in scope regardless of build type * Add descriptions * Add translation variables and fix tooltip * Use new icons * Add missing description after rebase * Fix build issues * Fix icons * Fix translation * Add missing description * Fix Ethereum icon * Update coverage
* MMI adds the Jwt dropdown * MMI prettier * review fixes * adds the component * adds tests and story file * lint & prettier fix * prettier fix * prettier and clean up * prettier and clean up
* added mmi code fencing * Fixed code fencing issue
Co-authored-by: legobeat <[email protected]>
…18470) * Revert changes made to stable permission display (UI design) * Add test for new component * Update paddings for install flow * Fix missing icons on snap installation flow * Update storybook path * Add targetSubjectMetadata param --------- Co-authored-by: legobeat <[email protected]> Co-authored-by: Frederik Bolding <[email protected]>
…alForAll method (#18660)
Sentry console logs were failing with the error "Error: TypeError: Cannot read properties of undefined (reading 'log')". This error has been fixed; now Sentry can log errors to the console. Co-authored-by: legobeat <[email protected]>
…te (#18670) * Fix swaps controller: update provider after networkIdStore state update * Listen for changes on networkController.store, instead of networkController.networkIdStore, in the swaps controller * Fix unit tests
* check for user agent * fix regex * fix lint * update link * add test * update message * update coverage * fix test names * update text * add whats new notification for firefox and ledger users * update action button link * update notification text * update viewed notification * update coverage * update coverage
PeterYinusa
force-pushed
the
Version-v10.29.0
branch
from
06f64b8 to
aa8d787
Compare
Co-authored-by: legobeat <[email protected]>
The mobile sync feature has been removed. It has been disabled for years. When we enable sync again, it will be using a different implementation. This has already been removed on the mobile side.
Update CHANGELOG.md Co-authored-by: Frederik Bolding <[email protected]> Update CHANGELOG.md Co-authored-by: Frederik Bolding <[email protected]> Update CHANGELOG.md Co-authored-by: Frederik Bolding <[email protected]> Update CHANGELOG.md Co-authored-by: Frederik Bolding <[email protected]> Update CHANGELOG.md Co-authored-by: Frederik Bolding <[email protected]> Update CHANGELOG.md Co-authored-by: Frederik Bolding <[email protected]> Update CHANGELOG.md Co-authored-by: Frederik Bolding <[email protected]> Update CHANGELOG.md Co-authored-by: Frederik Bolding <[email protected]> Update CHANGELOG.md Co-authored-by: Frederik Bolding <[email protected]> update
PeterYinusa
requested review from
a team,
kumavis and
brad-decker
as code owners
PeterYinusa
approved these changes
Apr 20, 2023
Builds ready [1c37e07]
Page Load Metrics (1403 ± 31 ms)
|
brad-decker
approved these changes
Apr 20, 2023
|
I am assigning a "DO-NOT-MERGE" label for a few minutes, while I double check that all necessary commits have been included in this RC |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 🚀