Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMI adds the note-to-trader component #18106

Merged
merged 17 commits into from
Mar 16, 2023
Merged

Conversation

zone-live
Copy link
Contributor

Explanation

This PR adds the MMI NoteToTrader component under the ui/components/institutional/ folder
Ref ticket: https://consensyssoftware.atlassian.net/browse/MMI-2645

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [06196da]
Page Load Metrics (1777 ± 143 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint982081362612
domContentLoaded125322081749291140
load126722961777298143
domInteractive125322081749291140
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #18106 (1c4f338) into develop (7215fc2) will increase coverage by 0.00%.
The diff coverage is 80.00%.

❗ Current head 1c4f338 differs from pull request most recent head b17ad3b. Consider uploading reports for the commit b17ad3b to get more accurate results

@@           Coverage Diff            @@
##           develop   #18106   +/-   ##
========================================
  Coverage    64.00%   64.00%           
========================================
  Files          910      911    +1     
  Lines        35505    35510    +5     
  Branches      9002     9002           
========================================
+ Hits         22724    22728    +4     
- Misses       12781    12782    +1     
Impacted Files Coverage Δ
...nts/institutional/note-to-trader/note-to-trader.js 80.00% <80.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [015214b]
Page Load Metrics (1546 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint973301325828
domContentLoaded12361945152217182
load12371945154617885
domInteractive12361944152217182
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@zone-live zone-live marked this pull request as ready for review March 13, 2023 09:39
@zone-live zone-live requested a review from a team as a code owner March 13, 2023 09:39
albertolive
albertolive previously approved these changes Mar 13, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [1c4f338]
Page Load Metrics (1562 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint993231254723
domContentLoaded1446175015608842
load1455175015628842
domInteractive1446175015608842
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@zone-live zone-live requested a review from NidhiKJha March 15, 2023 10:13
Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Just added a few component. Also, it would be great to have a story for this component to make it easy to review.

ui/components/institutional/note-to-trader/index.scss Outdated Show resolved Hide resolved
ui/components/institutional/note-to-trader/index.scss Outdated Show resolved Hide resolved
ui/components/institutional/note-to-trader/index.scss Outdated Show resolved Hide resolved
Polobandit23
Polobandit23 previously approved these changes Mar 15, 2023
@zone-live zone-live requested a review from Polobandit23 March 15, 2023 11:59
@zone-live zone-live requested review from NidhiKJha and removed request for Polobandit23 March 15, 2023 15:18
@zone-live zone-live requested review from Polobandit23 and albertolive and removed request for Polobandit23 March 15, 2023 16:27
@metamaskbot
Copy link
Collaborator

Builds ready [e87c829]
Page Load Metrics (1565 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint104150117126
domContentLoaded1412172815549445
load1412172815659244
domInteractive1412172815549445
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@zone-live zone-live merged commit 0a376fe into develop Mar 16, 2023
@zone-live zone-live deleted the MMI-2645-no-to-trader-component branch March 16, 2023 11:26
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants