-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMI adds the note-to-trader component #18106
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [06196da]
Page Load Metrics (1777 ± 143 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #18106 +/- ##
========================================
Coverage 64.00% 64.00%
========================================
Files 910 911 +1
Lines 35505 35510 +5
Branches 9002 9002
========================================
+ Hits 22724 22728 +4
- Misses 12781 12782 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Builds ready [015214b]
Page Load Metrics (1546 ± 85 ms)
Bundle size diffs
|
Builds ready [1c4f338]
Page Load Metrics (1562 ± 42 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Just added a few component. Also, it would be great to have a story for this component to make it easy to review.
Builds ready [e87c829]
Page Load Metrics (1565 ± 44 ms)
Bundle size diffs
|
Explanation
This PR adds the MMI
NoteToTrader
component under theui/components/institutional/
folderRef ticket: https://consensyssoftware.atlassian.net/browse/MMI-2645
Pre-merge author checklist
Pre-merge reviewer checklist