[FLASK] Snaps e2e test stability improvements

[bowensanders]

Using waitForElement instead of arbitrary delays in many locations
Using pasteIntoField instead of fill in a few locations
other delay changes as needed

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [53d328b]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1670 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	99	168	124	18	9
		domContentLoaded	1488	1866	1636	116	56
		load	1521	1890	1670	118	56
		domInteractive	1488	1866	1636	116	56

Bundle size diffs

• background: 0 bytes
• ui: 0 bytes
• common: 0 bytes

[codecov]

Codecov Report

Merging #18090 (2eb81e3) into develop (423e085) will increase coverage by 0.06%.
The diff coverage is 55.83%.

@@             Coverage Diff             @@
##           develop   #18090      +/-   ##
===========================================
+ Coverage    63.86%   63.92%   +0.06%     
===========================================
  Files          908      908              
  Lines        35390    35397       +7     
  Branches      8966     8974       +8     
===========================================
+ Hits         22599    22625      +26     
+ Misses       12791    12772      -19     

Impacted Files	Coverage Δ
app/scripts/controllers/preferences.js	77.16% <ø> (-2.73%)	⬇️
app/scripts/migrations/index.js	100.00% <ø> (ø)
shared/constants/metametrics.js	100.00% <ø> (ø)
shared/constants/network.ts	100.00% <ø> (ø)
...delete-network/confirm-delete-network.container.js	66.67% <0.00%> (ø)
ui/ducks/app/app.ts	62.28% <0.00%> (+1.60%)	⬆️
ui/ducks/metamask/metamask.js	76.19% <ø> (ø)
...rm-transaction/confirm-token-transaction-switch.js	5.26% <0.00%> (-3.07%)	⬇️
...tion-network-switch/confirmation-network-switch.js	11.11% <ø> (ø)
...pages/confirmation/templates/add-ethereum-chain.js	13.56% <0.00%> (-0.23%)	⬇️
... and 24 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[bowensanders]

Resolves issue #17643

[FrederikBolding]

left a few comments, most of them apply to all files

[metamaskbot]

Builds ready [b0d600d]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1693 ± 93 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	182	131	22	11
		domContentLoaded	1383	2024	1678	200	96
		load	1383	2025	1693	194	93
		domInteractive	1383	2024	1678	199	96

Bundle size diffs

• background: 0 bytes
• ui: 0 bytes
• common: 0 bytes

[metamaskbot]

Builds ready [2eb81e3]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1659 ± 65 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	99	177	132	19	9
		domContentLoaded	1286	1970	1637	147	71
		load	1381	1970	1659	136	65
		domInteractive	1286	1970	1637	147	71

Bundle size diffs

• background: 0 bytes
• ui: 0 bytes
• common: 0 bytes

[hmalik88]

LGTM