-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mobile sync feature #18692
Remove mobile sync feature #18692
Conversation
4ad70d0
to
ac5608d
Compare
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview: 🚮 Removed packages: [email protected] |
ac5608d
to
8026b9b
Compare
The mobile sync feature has been removed. It has been disabled for years. When we enable sync again, it will be using a different implementation. This has already been removed on the mobile side.
8026b9b
to
76d491c
Compare
Builds ready [555bb57]
Page Load Metrics (1566 ± 45 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥
Explanation
The mobile sync feature has been removed. It has been disabled for years. When we enable sync again, it will be using a different implementation. This has already been removed on the mobile side.
Manual Testing Steps
Check that the mobile sync feature has been removed (it was in the advanced settings).
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.