Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mobile sync feature #18692

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Remove mobile sync feature #18692

merged 3 commits into from
Apr 20, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 20, 2023

Explanation

The mobile sync feature has been removed. It has been disabled for years. When we enable sync again, it will be using a different implementation. This has already been removed on the mobile side.

Manual Testing Steps

Check that the mobile sync feature has been removed (it was in the advanced settings).

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@Gudahtt Gudahtt force-pushed the remove-mobile-sync branch from 4ad70d0 to ac5608d Compare April 20, 2023 15:45
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: [email protected]

@Gudahtt Gudahtt force-pushed the remove-mobile-sync branch from ac5608d to 8026b9b Compare April 20, 2023 15:48
The mobile sync feature has been removed. It has been disabled for
years. When we enable sync again, it will be using a different
implementation. This has already been removed on the mobile side.
@Gudahtt Gudahtt force-pushed the remove-mobile-sync branch from 8026b9b to 76d491c Compare April 20, 2023 15:52
@Gudahtt Gudahtt marked this pull request as ready for review April 20, 2023 15:54
@Gudahtt Gudahtt requested review from a team and kumavis as code owners April 20, 2023 15:54
@Gudahtt Gudahtt requested a review from digiwand April 20, 2023 15:54
@PeterYinusa PeterYinusa added the release-10.29.0 Issue or pull request that will be included in release 10.29.0 label Apr 20, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [555bb57]
Page Load Metrics (1566 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint96152117168
domContentLoaded1254165415558943
load1254169115669345
domInteractive1254165415558943
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -1841 bytes
  • ui: -195379 bytes
  • common: 9 bytes

Copy link
Contributor

@PeterYinusa PeterYinusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@Gudahtt Gudahtt merged commit 3776f4a into develop Apr 20, 2023
@Gudahtt Gudahtt deleted the remove-mobile-sync branch April 20, 2023 16:59
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.29.0 Issue or pull request that will be included in release 10.29.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants