make network-controller methods overwrite rather than merge provider state

[adonesky1]

This changes several places in the NetworkController where we call updateState - which merges partial state - on an ObservableStore instance, to putState - which wholly overwrites state in that store. This pattern of immutable state mutation is safer and avoids confusing state scenarios where, for instance, a rollbackToPreviousProvider call results in a provider state with some of the state of the provider we failed to connect alongside the the details of the provider we rolled back to.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [8e756f4]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1725 ± 51 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	100	168	124	16	8
		domContentLoaded	1571	1905	1701	94	45
		load	1571	2015	1725	106	51
		domInteractive	1571	1905	1701	94	45

Bundle size diffs [🚀 Bundle size reduced!]

• background: -12 bytes
• ui: 0 bytes
• common: 0 bytes

[codecov]

Codecov Report

Merging #18127 (5c33af2) into develop (14b1555) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop   #18127   +/-   ##
========================================
  Coverage    63.93%   63.93%           
========================================
  Files          908      908           
  Lines        35399    35399           
  Branches      8976     8976           
========================================
  Hits         22632    22632           
  Misses       12767    12767           

Impacted Files	Coverage Δ
.../scripts/controllers/network/network-controller.js	87.43% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[metamaskbot]

Builds ready [5c33af2]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1534 ± 36 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	321	124	48	23
		domContentLoaded	1413	1724	1524	74	36
		load	1413	1724	1534	74	36
		domInteractive	1413	1724	1524	74	36

Bundle size diffs [🚀 Bundle size reduced!]

• background: -15 bytes
• ui: 0 bytes
• common: 0 bytes

[Gudahtt]

LGTM!

[mcmire]

LGTM!