Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Fix overflow issues with text coming from snap UI #18169

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

FrederikBolding
Copy link
Member

Explanation

Fixes a few overflow issues with text coming from snap UI, by wrapping instead of allowing overflow.

Fixes #18168

Screenshots/Screencaps

Before

Screenshot 2023-03-15 at 14 55 35

After

Screenshot 2023-03-15 at 14 40 53

Manual Testing Steps

  1. Create a snap using text() from @metamask/snaps-ui
  2. Have the string inside text() be one very long word
  3. View your snap UI and check that it doesn't overflow

@FrederikBolding FrederikBolding requested a review from a team as a code owner March 15, 2023 14:10
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #18169 (b0edcf3) into develop (1482cd1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #18169   +/-   ##
========================================
  Coverage    64.11%   64.11%           
========================================
  Files          910      910           
  Lines        35517    35517           
  Branches      9009     9009           
========================================
  Hits         22769    22769           
  Misses       12748    12748           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [b0edcf3]
Page Load Metrics (1552 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89136107136
domContentLoaded1397171615298842
load1397173315529646
domInteractive1397171615298842
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@FrederikBolding FrederikBolding merged commit dce4c6d into develop Mar 16, 2023
@FrederikBolding FrederikBolding deleted the fb/fix-snap-ui-text-overflow branch March 16, 2023 10:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FLASK] Better support long lines in custom confirmation screens
4 participants