-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLASK] Add tooltips to show info about a permission #17685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
commented
Feb 9, 2023
GuillaumeRx
previously approved these changes
Feb 9, 2023
Code LGTM, build is not passing though |
Builds ready [22551a5]
Page Load Metrics (1502 ± 136 ms)
Bundle size diffs
|
Builds ready [22551a5]
Page Load Metrics (1502 ± 136 ms)
Bundle size diffs
|
Mrtenz
force-pushed
the
mrtenz/permission-tooltips
branch
2 times, most recently
from
February 16, 2023 10:34
cba6ec9
to
ad73413
Compare
Mrtenz
force-pushed
the
mrtenz/permission-tooltips
branch
from
March 16, 2023 15:10
933c756
to
7919b6a
Compare
Builds ready [b61482d]
Page Load Metrics (1698 ± 79 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #17685 +/- ##
===========================================
- Coverage 63.96% 63.93% -0.03%
===========================================
Files 914 914
Lines 35621 35639 +18
Branches 9028 9035 +7
===========================================
+ Hits 22783 22785 +2
- Misses 12838 12854 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Mrtenz
force-pushed
the
mrtenz/permission-tooltips
branch
from
March 17, 2023 12:59
9e06362
to
03928f2
Compare
Mrtenz
force-pushed
the
mrtenz/permission-tooltips
branch
from
March 20, 2023 10:28
03928f2
to
58a5ff3
Compare
FrederikBolding
previously approved these changes
Mar 20, 2023
FrederikBolding
approved these changes
Mar 20, 2023
Builds ready [803bd62]
Page Load Metrics (1719 ± 67 ms)
Bundle size diffs
|
GuillaumeRx
approved these changes
Mar 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This adds support for showing tooltips on permissions, and adds a tooltip to all the Snaps-related permissions.
Closes #17624.
Before
After
Manual Testing Steps
test-snaps
.Pre-merge author checklist
Pre-merge reviewer checklist