AvatarBase font-size logic #18203
Merged
AvatarBase font-size logic #18203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
added
area-UI
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
force-pushed
the
fix/avatar-fallback
branch
from
8e41be2 to
3035a3f
Compare
georgewrmarshall
requested review from
pedronfigueiredo,
NidhiKJha and
darkwing
and removed request for
pedronfigueiredo
darkwing
previously approved these changes
Mar 16, 2023
georgewrmarshall
force-pushed
the
fix/avatar-fallback
branch
from
3035a3f to
c2d0934
Compare
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| text-transform: uppercase; |
There was a problem hiding this comment.
Removing in favour of Box props
georgewrmarshall
force-pushed
the
fix/avatar-fallback
branch
from
c2d0934 to
2a70217
Compare
georgewrmarshall
changed the title
georgewrmarshall
force-pushed
the
fix/avatar-fallback
branch
2 times, most recently
from
6ead1f3 to
ca7d178
Compare
Comment on lines
+103
to
+105
| expect(getByTestId('success')).toHaveClass( | ||
| 'mm-text--color-success-default', | ||
| ); |
There was a problem hiding this comment.
We shouldn't have to update this the text component should use the Box component color prop have created an issue here #18209 cc @garrettbear
darkwing
approved these changes
Mar 17, 2023
NidhiKJha
approved these changes
Mar 17, 2023
…ont size logic based on avatar size
georgewrmarshall
force-pushed
the
fix/avatar-fallback
branch
from
a12ac41 to
764b7f4
Compare
Builds ready [764b7f4]
Page Load Metrics (1840 ± 80 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #18203 +/- ##
===========================================
+ Coverage 63.96% 63.97% +0.01%
===========================================
Files 914 914
Lines 35623 35630 +7
Branches 9030 9033 +3
===========================================
+ Hits 22784 22791 +7
Misses 12839 12839
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently the fallback for AvatarNetwork and AvatarToken is a letter but at the time of creation there was no
Textcomponent. The letter also breaks at sizexsof the avatar sizesThis PR changes the root component of the
AvatarBasecomponent to aTextcomponent and adds logic to size it according to the avatar sizes. It also:Adds storybook updates
Adds documentation
Adds tests
Fixes issue in UX: Multichain: Added TokenList Component #17859
Screenshots/Screencaps
Before
before.mov
After
after.mov
Manual Testing Steps
AvatarNetworkcheck the controls and stories and docsAvatarTokenPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.