Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Text component to use Box color prop #18209

Closed
georgewrmarshall opened this issue Mar 17, 2023 · 0 comments · Fixed by #18246
Closed

Refactor Text component to use Box color prop #18209

georgewrmarshall opened this issue Mar 17, 2023 · 0 comments · Fixed by #18246
Assignees
Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension

Comments

@georgewrmarshall
Copy link
Contributor

Description

Currently the Text component is using it's own logic and classNames to decide on the css color. This is creating extra classNames and CSS that isn't necessary as well as complicates tests when change the root component from Box to Text.

The Text component should be refactored to just utilize the Box color prop instead of creating it's own version

Technical Details

  • Remove the color prop logic and css from the Text component
  • Update Tests

Acceptance Criteria

  • Text component uses the Box component color prop
  • Checking for a color class on the Text component should just check for the box--color-[color]
@georgewrmarshall georgewrmarshall added area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension labels Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants