Merge of new changes, resoled conflicts #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed fujidaiti#151. Manually reverted fujidaiti#102 to remove `ImplicitSheetControllerScope` which is the cause of fujidaiti#151 and is no longer needed at this time.
…ls = 0.0 (fujidaiti#164) Fixes fujidaiti#163. **New APIs** - `ExtentScopeBuilder` **Internal changes** - Removed `SheetExtentConfig`, `SheetExtentFactory`, and their subclasses. - Accordingly, `SheetExtentScope` widgets now also take responsibility for creating the `SheetExtent`s they host. - Moved the responsibility for managing the scope keys of the local `SheetExtentScope`s from `NavigationSheetExtent` to each `NavigationSheetRoute`. **Misc** - Added a regression test for fujidaiti#163. - Bumped the version to 0.7.2.
…Sheet (fujidaiti#165) Fixes fujidaiti#139. Essentially the issue was fixed by the changes in fujidaiti#164, so this PR just adds some missing pieces to fully support non-`NavigationSheetRoute`s in `NavigationSheet`. - Relaxed assertion to allow routes other than `NavigationSheetRoute`. - Removed equals and hashCode to reduce unnecessary complexity in code. - Implemented `canTransitionFrom` and `canTransitionTo` of `NavigationSheetRoute`. - Added a regression test of fujidaiti#139. - Disabled `unneecssary_parenthesis` rule. - Bumped the version to 0.7.3.
…ujidaiti#171) Closes fujidaiti#159. ## Breaking Changes - Removed the `StretchingSheetPhysics.stretchingRange` property. - Added `StretchingBehavior` and its subclasses as the replacements. - `FixedStretchingBehavior`: Allows a sheet to stretch by up to a fixed amount. - `DirectionAwareStretchingBehavior`: Similar to `FixedStretchingBehavior`, but can accept different values for upward and downward directions. ## Misc - Added the migration guide. - Updated README and CHANGELOG.
`StretchingSheetPhysics` was renamed to `BouncingSheetPhysics` to better reflect its behavior, as it does not change the actual height of the sheet, but rather allows its position to go beyond the content bounds. Accordingly, the other related classes and properties were also renamed.
This PR fixes the following comments that should have been included in fujidaiti#173. - fujidaiti#173 (comment) - fujidaiti#173 (comment) - fujidaiti#173 (comment)
fujidaiti#182) Fixes fujidaiti#168. The `SheetExtentScope` has been modified to no longer rely on an inherited sheet controller as a fallback. Instead, the sheet controller is now explicitly provided in the constructor of `SheetExtentScope` when necessary. Additional changes: - Added a new example demonstrating an iOS-style modal NavigationSheet with go_router. - Added a regression test for the issue. - Added more tests to cover the functionality around inheriting a sheet controller. - Bumped the version number to 0.8.1.
Fixes fujidaiti#14. The sheet position adjustment strategy of `AnimatedSheetActivity`, which is used when either the sheet content size or the viewport size changes, was modified to: 1. append the delta of `MediaQueryData.viewInsets.bottom` (the keyboard height) to keep the visual sheet position unchanged, and 3. if the animation is still running, start a new linear animation to bring the sheet position to the recalculated final position in the remaining duration. We use a linear curve here because starting a curved animation in the middle of another curved animation tends to look jerky.
## Fixes / Closes (optional) None. ## Description This PR prepares for the upcoming `SheetActivity.ignorePointer` API. In these changes, the implementation of `SheetContext` will be moved from `SheetExtentScopeState` to the State classes of each sheet widget. As a result, the `SheetKeyboardDismissible` widget will need to be an ancestor of a sheet. This is because `SheetContext.notificationContext` will be at the sheet widget itself (currently it is at `SheetExtentScope`, which is a descendant of the sheet). Consequently, the `SheetKeyboardDismissible` internally inserted into the sheet subtree won't be able to catch `SheetNotification`s, resulting in the keyboard dismissing behavior not working. ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [x] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [x] Contains breaking changes - [x] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Fixes / Closes (optional) Fixes fujidaiti#166. ## Description This PR introduces `SheetActivity.shouldIgnorePointer`, a flag that indicates whether the sheet should prevent its content from receiving the pointer events. `TransitionSheetActivity` for `NavigationSheet` sets this flag to `true` to avoid potential issues that caused by user gestures during the unstable state of route transitions. ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [ ] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Fixes / Closes (optional) Fixes fujidaiti#179. ## Description Moved the notification dispatch logic from `SheetExtent.beginActivity()` to the individual `SheetActivity` classes, as they have a better understanding of what kind of notification should be dispatched and when. This refactoring will implicitly fix fujidaiti#179, as the assertions that caused the errors reported in the issue have also been removed in this PR. ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [ ] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
…fujidaiti#196) ## Fixes / Closes (optional) Fixes fujidaiti#190. ## Description This PR fixes an incorrect use of the `ScrollActivity.shouldIgnorePointer` flag that has caused the issue. Previously, `DragScrollDrivenSheetActivity` used to start a `SheetContentBallisticScrollActivity` with `shouldIgnorePointer` set to `false` when a drag gesture ended. However, it should actually be `true` except in a special case. This is because setting `ScrollActivity.shouldIgnorePointer` to `true` means that clickable items in the scroll view cannot receive pointer events while performing that activity, and the scroll view may receive them instead. So if the flag is set to `false` during a ballistic scroll animation and there are any clickable items in the scroll view, the scroll view may not be able to receive the pointer events, resulting in the ballistic scroll animation not stopping in response to user gestures. After this PR is merged, `SheetContentBallisticScrollActivity` will be started with the same value of `shouldIgnorePointer` as the previous `ScrollActivity`. Note that we can't use a hardcoded value of `true` here, as it may need to be `false` in a special case where the pointer device kind is `PointerDeviceKind.trackpad`. ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [ ] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Fixes / Closes (optional) None. ## Description In this PR, the following new features have been added: - `SheetDragCancelNotification`, which is dispatched when a drag is canceled. - `SheetDragCancelDetails`, which represents the final state of `SheetDragController.details` when the tracked drag gesture is canceled. ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [ ] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [x] Updated CHANGELOG
## Fixes / Closes (optional) <!-- List any issues or pull requests that this PR fixes or closes. Use the format: "Fixes fujidaiti#123" or "Closes #456". --> None. ## Description <!-- Provide a clear and concise description of what this PR does. Explain the problem it solves and the approach you've taken. --> `SheetExtentScopeState` no longer implements `SheetContext`. Instead, these implementations have been moved to `SheetContextStateMixin`, which is mixed in by all the `*SheetState` classes. ## Summary (check all that apply) <!-- Mark the boxes that apply to this PR. Add details if necessary. --> - [x] Modified / added code - [ ] Modified / added tests - [ ] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Fixes / Closes (optional) <!-- List any issues or pull requests that this PR fixes or closes. Use the format: "Fixes fujidaiti#123" or "Closes #456". --> - Closes fujidaiti#156. ## Description <!-- Provide a clear and concise description of what this PR does. Explain the problem it solves and the approach you've taken. --> Also added the [topics](https://dart.dev/tools/pub/pubspec#topics) to pubspec.yaml. ## Summary (check all that apply) <!-- Mark the boxes that apply to this PR. Add details if necessary. --> - [ ] Modified / added code - [ ] Modified / added tests - [ ] Modified / added examples - [x] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [x] Incremented version number - [x] Updated CHANGELOG
## Fixes / Closes (optional) None. ## Summary (check all that apply) <!-- Mark the boxes that apply to this PR. Add details if necessary. --> - [ ] Modified / added code - [ ] Modified / added tests - [ ] Modified / added examples - [x] Modified / added others (pubspec.yaml, workflows, etc...) - [x] Fixed typos in CHANGELOG - [x] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
…ujidaiti#209) ## Fixes / Closes (optional) Fixes fujidaiti#207. ## Description This PR improves floating-point value comparisons throughout the codebase to address an existing issue and prevent potential problems related to floating-point precision errors. For example, fujidaiti#207 was caused by infinite recursion of `SheetContentScrollPositionOwner.goBallisticWithScrollPosition` calls, triggered by `ScrollMetrics.outOfRange` always being true in `ScrollPhysics.createBallisticSimulation` due to such a floating-point precision error. ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [ ] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [x] Incremented version number - [x] Updated CHANGELOG
## Fixes / Closes (optional)
None.
## Description
After the release of Flutter 3.24, pub.dev and `pana` have started to
report the following warning:
```
40/50 points: code has no errors, warnings, lints, or formatting issues
INFO: 'onPopInvoked' is deprecated and shouldn't be used. Override onPopInvokedWithResult instead. This feature was deprecated after v3.22.0-12.0.pre.
lib/src/modal/modal_sheet.dart:395:13
╷
395 │ route.onPopInvoked(didPop);
│ ^^^^^^^^^^^^
```
This decreases the package's pub points for the *Pass-static-analysis*
section from 50 to 40, but the current CI requires it to always be 50,
resulting in no PR passing the CI.
Although it is possible to fix this warning by following [the migration
guide](https://docs.flutter.dev/release/breaking-changes/popscope-with-result),
we are not doing this for now as it breaks backward compatibility.
Instead, this PR works around this CI issue by decreasing the required
pub points for that section to 40 until Flutter 3.24 is widely adopted
in the community.
## Summary (check all that apply)
- [ ] Modified / added code
- [ ] Modified / added tests
- [ ] Modified / added examples
- [x] Modified / added others (pubspec.yaml, workflows, etc...)
- [ ] Updated README
- [ ] Contains breaking changes
- [ ] Created / updated migration guide
- [ ] Incremented version number
- [ ] Updated CHANGELOG
…n NavigationSheet (fujidaiti#215) ## Fixes / Closes (optional) - Fixes fujidaiti#195 ## Description Added handling logic for the software keyboard overlay on the navigation sheet. ## Summary (check all that apply) - [x] Modified / added code - [ ] Modified / added tests - [x] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [x] Incremented version number - [x] Updated CHANGELOG
…ng (fujidaiti#219) ## Fixes / Closes (optional) <!-- List any issues or pull requests that this PR fixes or closes. Use the format: "Fixes fujidaiti#123" or "Closes #456". --> Fixes fujidaiti#214. ## Description This PR adds `holdWithScrollPosition()` to `ScrollableSheetExtent` to handle press-and-hold gestures in scrollable sheet content. It starts a `HoldScrollDrivenSheetActivity`, which stops momentum scrolling (if it is running). The absence of this handling logic hasn't been problematic for simple ListViews or PageViews with only one page. This is because the SDK triggers `ScrollPosition.drag()` immediately after calling `ScrollPosition.hold()` when the user performs a press-and-hold gesture. However, in a PageView with multiple ListViews, `drag()` won't be called after `hold()` until the user actually moves their finger. ## Summary (check all that apply) <!-- Mark the boxes that apply to this PR. Add details if necessary. --> - [x] Modified / added code - [x] Modified / added tests - [x] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [x] Incremented version number - [x] Updated CHANGELOG
## Fixes / Closes (optional) None. ## Description Some improvements in the PR template. ## Summary (check all that apply) - [ ] Modified / added code - [ ] Modified / added tests - [ ] Modified / added examples - [x] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Related issues (optional) None. ## Summary (check all that apply) - [ ] Modified / added code - [ ] Modified / added tests - [x] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
…#224) ## Related issues (optional) None. ## Description According to [dorny/test-reporter](https://github.com/dorny/test-reporter?tab=readme-ov-file#recommended-setup-for-public-repositories): > Workflows triggered by pull requests from forked repositories are > executed with read-only token and therefore can't create check runs. As a workaround, this PR modifies the workflow to generate a test report only when triggered by the original repository. ## Summary (check all that apply) - [ ] Modified / added code - [ ] Modified / added tests - [ ] Modified / added examples - [x] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Related issues (optional) None. ## Description This change prevents unexpected dependency upgrades during the CI process, as observed in [this GitHub Actions log](https://github.com/fujidaiti/smooth_sheets/actions/runs/10529347759/job/29176913631#step:5:27). ## Summary (check all that apply) - [ ] Modified / added code - [ ] Modified / added tests - [ ] Modified / added examples - [x] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Description Currently, our CI pipeline only runs when `*.dart` files are modified. This PR extends the CI trigger to include changes to `pubspec.*` files, ensuring that dependency updates are also properly tested. ## Summary (check all that apply) - [ ] Modified / added code - [ ] Modified / added tests - [ ] Modified / added examples - [x] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Related issues (optional) Closes fujidaiti#162. ## Description This PR adds the `swipeDismissSensitivity` property to `ModalSheetRoute` and related classes to support a way to tweak the sensitivity of the swipe-to-dismiss action. ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [x] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [x] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [x] Incremented version number - [x] Updated CHANGELOG --------- Co-authored-by: fujidaiti <[email protected]> Co-authored-by: Daichi Fujita <[email protected]>
## Description As there are no breaking changes. ## Summary (check all that apply) - [ ] Modified / added code - [ ] Modified / added tests - [ ] Modified / added examples - [x] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
…ersions in CI (fujidaiti#235) ## Related issues (optional) Closes fujidaiti#229. ## Description The workflow file was updated to run unit tests and static analysis for both the lowest and highest supported Flutter SDK versions. This approach helps detect potential compatibility issues across the entire supported SDK range. For example, issue fujidaiti#144 stemmed from accidentally using newly added APIs in Flutter 3.22 that don't exist in lower versions, while issue fujidaiti#233 arose due to a breaking change introduced in Flutter 3.24. ## Summary (check all that apply) - [ ] Modified / added code - [ ] Modified / added tests - [ ] Modified / added examples - [x] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Description Added regression tests for fujidaiti#233 and pinned Flutter version to v3.22.3 for development and CI. This downgrade was necessary as tests fail with Flutter 3.24+ due to a [breaking change](https://docs.flutter.dev/release/breaking-changes/popscope-with-result), which caused that issue. The fix for fujidaiti#233 is not included here as it requires Flutter 3.24+, while the main branch will use v3.22.3 post-merge. To accommodate this version disparity, the fix will be implemented in a separate branch, providing distinct solutions for users of Flutter 3.24+ and 3.22.3 or earlier. ## Summary (check all that apply) - [ ] Modified / added code - [x] Modified / added tests - [ ] Modified / added examples - [x] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
) ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [ ] Modified / added examples - [x] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Related issues (optional) Fixes fujidaiti#212. ## Description This PR fixes a problem related to floating-point precision errors in the same manner as fujidaiti#209, taking the top edge of scrollable widgets into account (the previous fix addressed only the bottom edge). ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [ ] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Related issues (optional) Fixes fujidaiti#193. ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [ ] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [x] Contains breaking changes - [x] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
…iti#243) ## Related issues (optional) - Fixes fujidaiti#226 - Fixes fujidaiti#192 ## Description This PR refines the `didFinalizeDimensions` method of `IdleActivity` to address the unstable behavior of the sheet when opening or closing the on-screen keyboard, as reported in fujidaiti#192 and fujidaiti#226. ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [x] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [ ] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
… on ScrollableSheet (fujidaiti#246) ## Related issues (optional) Fixes fujidaiti#245. ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [ ] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
…i#247) ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [ ] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [x] Contains breaking changes - [x] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Description - DRY the bottom viewport inset handling logic shared across activities - Done "use controller.value instead" - Change signature of didChangeBoundaryConstraints - Rename applyUserDragUpdate to onDragUpdate - Rename applyUserDragEnd to onDragEnd - Rename SheetGestureTamperer to SheetGestureProxy - Fix warnings ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [ ] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Related issues (optional) Closes fujidaiti#141. ## Description Refer to the migration guide to see the changes. ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [x] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [x] Updated README - [x] Contains breaking changes - [x] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Description - Rename `snapTo` to `anchors` - Rename `snappingBehavior` to `behavior` ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [x] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [x] Contains breaking changes - [x] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
## Description Added .idea/ to version control and added run configurations for better DX in Android Studio. ## Summary (check all that apply) - [ ] Modified / added code - [ ] Modified / added tests - [ ] Modified / added examples - [x] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
Updated all the run configuration files to use absolute paths for the entry point files.
## Related issues (optional) Fixes fujidaiti#250. ## Description This PR modifies `_SwipeDismissibleController` to ensure that the transition animation curve remains linear during the animation triggered by a swipe-to-dismiss gesture. This is crucial to prevent the sheet from jerking when the user swipes it down, as reported in fujidaiti#250. See the comments in the `_handleDragEnd` method for a more detailed explanation. ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [ ] Modified / added examples - [x] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
Updated the Gradle and AGP versions in the example project to migrate to the latest version of Android Studio (Ladybug).
## Description Support WASM.  ## Summary (check all that apply) - [x] Modified / added code - [x] Modified / added tests - [x] Modified / added examples - [ ] Modified / added others (pubspec.yaml, workflows, etc...) - [ ] Updated README - [ ] Contains breaking changes - [ ] Created / updated migration guide - [ ] Incremented version number - [ ] Updated CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues (optional)
None.
Description
Blah blah blah.
Summary (check all that apply)