Fix: Press-and-hold gesture in PageView doesn't stop momentum scrolling #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Closes (optional)
Fixes #214.
Description
This PR adds
holdWithScrollPosition()toScrollableSheetExtentto handle press-and-hold gestures in scrollable sheet content. It starts aHoldScrollDrivenSheetActivity, which stops momentum scrolling (if it is running).The absence of this handling logic hasn't been problematic for simple ListViews or PageViews with only one page. This is because the SDK triggers
ScrollPosition.drag()immediately after callingScrollPosition.hold()when the user performs a press-and-hold gesture. However, in a PageView with multiple ListViews,drag()won't be called afterhold()until the user actually moves their finger.Summary (check all that apply)