Fix: Momentum scrolling continues despite press and hold in list view #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujidaiti
changed the title
fujidaiti
force-pushed
the
fix-scrollable-ignore-tap
branch
3 times, most recently
from
21ab604 to
8d1b0a5
Compare
fujidaiti
force-pushed
the
fix-scrollable-ignore-tap
branch
from
8d1b0a5 to
00539af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Closes (optional)
Fixes #190.
Description
This PR fixes an incorrect use of the
ScrollActivity.shouldIgnorePointerflag that has caused the issue.Previously,
DragScrollDrivenSheetActivityused to start aSheetContentBallisticScrollActivitywithshouldIgnorePointerset tofalsewhen a drag gesture ended. However, it should actually betrueexcept in a special case. This is because settingScrollActivity.shouldIgnorePointertotruemeans that clickable items in the scroll view cannot receive pointer events while performing that activity, and the scroll view may receive them instead. So if the flag is set tofalseduring a ballistic scroll animation and there are any clickable items in the scroll view, the scroll view may not be able to receive the pointer events, resulting in the ballistic scroll animation not stopping in response to user gestures.After this PR is merged,
SheetContentBallisticScrollActivitywill be started with the same value ofshouldIgnorePointeras the previousScrollActivity. Note that we can't use a hardcoded value oftruehere, as it may need to befalsein a special case where the pointer device kind isPointerDeviceKind.trackpad.Summary (check all that apply)