Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #248

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Refactor #248

merged 7 commits into from
Sep 20, 2024

Conversation

fujidaiti
Copy link
Owner

@fujidaiti fujidaiti commented Sep 20, 2024 •
edited
Loading

Description

  • DRY the bottom viewport inset handling logic shared across activities
  • Done "use controller.value instead"
  • Change signature of didChangeBoundaryConstraints
  • Rename applyUserDragUpdate to onDragUpdate
  • Rename applyUserDragEnd to onDragEnd
  • Rename SheetGestureTamperer to SheetGestureProxy
  • Fix warnings

Summary (check all that apply)

  • Modified / added code
  • Modified / added tests
  • Modified / added examples
  • Modified / added others (pubspec.yaml, workflows, etc...)
  • Updated README
  • Contains breaking changes
    • Created / updated migration guide
  • Incremented version number
    • Updated CHANGELOG

@fujidaiti fujidaiti self-assigned this Sep 20, 2024
@fujidaiti fujidaiti enabled auto-merge (squash) September 20, 2024 15:44
@fujidaiti fujidaiti disabled auto-merge September 20, 2024 15:45
@fujidaiti fujidaiti enabled auto-merge (squash) September 20, 2024 15:45
@fujidaiti fujidaiti merged commit c65505a into main Sep 20, 2024
9 checks passed
@fujidaiti fujidaiti deleted the refactor branch September 20, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fujidaiti fujidaiti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fujidaiti