Refactor notification dispatch mechanism #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujidaiti
force-pushed
the
refactor-notifications
branch
from
6273bd0 to
5efd3f1
Compare
fujidaiti
force-pushed
the
refactor-notifications
branch
from
e9c0a70 to
84e6686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Closes (optional)
Fixes #179.
Description
Moved the notification dispatch logic from
SheetExtent.beginActivity()to the individualSheetActivityclasses, as they have a better understanding of what kind of notification should be dispatched and when. This refactoring will implicitly fix #179, as the assertions that caused the errors reported in the issue have also been removed in this PR.Summary (check all that apply)