Rename stretching to bouncing
#173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujidaiti
commented
Jun 20, 2024
Comment on lines
+33
to
+34
| - [FixedBouncingBehavior](https://pub.dev/documentation/smooth_sheets/latest/smooth_sheets/FixedBouncingBehavior-class.html), which stretches the sheet by a fixed amount. | ||
| - [DirectionAwareBouncingBehavior](https://pub.dev/documentation/smooth_sheets/latest/smooth_sheets/DirectionAwareBouncingBehavior-class.html), which stretches the sheet by a fixed amount, based on the direction of a drag. |
There was a problem hiding this comment.
Use bounce instead of stretch
fujidaiti
commented
Jun 20, 2024
|
|
||
| ### New way to control the bouncing behavior of a sheet | ||
|
|
||
| [BouncingSheetBehavior](https://pub.dev/documentation/smooth_sheets/latest/smooth_sheets/BouncingSheetBehavior-class.html) was added as the new way to control the stretching behavior of a sheet. It replaces `StretchingSheetPhysics.stretchingRange` property, which has been removed. |
There was a problem hiding this comment.
as the new way to control the stretching behavior
"stretching"
fujidaiti
commented
Jun 20, 2024
| @@ -36,7 +36,7 @@ void main() { | |||
| group('$SheetPhysics subclasses', () { | |||
| test('can create dynamic inheritance relationships', () { | |||
| const clamp = ClampingSheetPhysics(); | |||
| const stretch = StretchingSheetPhysics(); | |||
fujidaiti
added a commit
that referenced
this pull request
Jun 20, 2024
This PR fixes the following comments that should have been included in #173. - #173 (comment) - #173 (comment) - #173 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StretchingSheetPhysicswas renamed toBouncingSheetPhysicsto better reflect its behavior, as it does not change the actual height of the sheet, but rather allows its position to go beyond the content bounds. Accordingly, the other related classes and properties were also renamed.