Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach default controller to sheet if not explicitly specified #102

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Attach default controller to sheet if not explicitly specified #102

merged 1 commit into from
Apr 22, 2024

Conversation

fujidaiti
Copy link
Owner

@fujidaiti fujidaiti commented Apr 22, 2024 •
edited
Loading

Closes #100. This PR contains internal changes only.

  • Made SheetContainer.controller mandatory
  • Added ImplicitSheetController, which ensures that a sheet controller is available in the subtree
  • Changed all sheets to use an ImplicitSheetController to prepare a controller for the internal SheetContainer

@fujidaiti fujidaiti self-assigned this Apr 22, 2024
@fujidaiti fujidaiti merged commit 9b886fe into main Apr 22, 2024
7 checks passed
@fujidaiti fujidaiti deleted the default-controller branch April 22, 2024 12:11
@kmorl kmorl mentioned this pull request May 31, 2024
Open
fujidaiti added a commit that referenced this pull request Jun 3, 2024
@fujidaiti
Manually revert #102
72d8953
@fujidaiti fujidaiti mentioned this pull request Jun 6, 2024
Merged
fujidaiti added a commit that referenced this pull request Jun 6, 2024
@fujidaiti
Fix crash when getting attached controller from sub-tree (#160)
6b3b455 
Fixed #151.

Manually reverted #102 to remove `ImplicitSheetControllerScope` which is
the cause of #151 and is no longer needed at this time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fujidaiti fujidaiti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attach default controller to sheet if not explicitly specified
1 participant
@fujidaiti