Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.27.0 #2186

Merged
merged 177 commits into from
Apr 30, 2020
Merged

Release v1.27.0 #2186

merged 177 commits into from
Apr 30, 2020

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Apr 27, 2020 •
edited
Loading

Release for Gutenberg Mobile v1.27.0

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

To test:

Bug fix

New feature & Improvement

Test plan

  • Use the main WP apps to test the changes above.
  • Check WPAndroid and WPiOS PRs if there are specific tests to run.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Release number was bumped
  • Aztec dependencies are pointing to a stable release
    • iOS: 'grep WordPressAztec-iOS RNTAztecView.podspec'
    • Android: 'grep aztecVersion react-native-aztec/android/build.gradle'
  • Gutenberg 'Podfile' and 'Podfile.lock' inside './ios/' are updated to the release number
  • Bundle package of the release is updated
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release

Tug and others added 30 commits February 19, 2020 14:41
@Tug
Jetpack editor basic setup
369c173
@Tug
prettier
4527d76
@Tug
Add support for contact-info inner blocks: address email and phone
99fb15a
@SergioEstevao
Update GB reference.
ba05948
@Tug
Try fetching /gutenberg/available-extensions
d1c4d90
@Tug
Explicitely import native compatible blocks
9a52618
@SergioEstevao
Merge branch 'develop' into issue/video_block_dont_force_fullscreen_o…
05d5f7a 
…n_ios

# Conflicts:
#	gutenberg
@SergioEstevao
Update GB reference.
bfbbe1a
@Tug
Skip apiFetch for now while WP REST API Auth is not yet supported
ded8fff
@chipsnyder
Add tests for Latest-Posts Bock
2a16c92
@chipsnyder
Have the Automation tests Scroll the Block window to help locate Bloc…
deee22c 
…k buttons on Android
@cameronvoell
Update jetpack reference
2cbb7a6
@mkevins
Update gutenberg reference
ff15683
@mkevins
Merge branch 'develop' into feature/cover-block-uploads-enable-dev-on…
45ddf0b 
…ly-and-progress
Update Gutenberg ref
6ae0d7c
Merge with develop
07b5cf1
Update Gutenberg ref
362e01a
Merge with develop
c76396d
@SergioEstevao
New template for release PRs
e368e0c 
This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md`
@SergioEstevao
Update template file.
0d6fed4
@jbinda
Fix: remove extra padding for post title and first Paragraph block (#…
57eb178 
…2095)

* Fix: remove extra padding for post title and first `Paragraph` block
Merge pull request #2060 from wordpress-mobile/rnmobile/latest-post-t…
6ff600a 
…ests

Add tests for Latest-Posts Bock
Update Gutenberg ref
1fb1976
@maxme
Add a new androidReplacements function to comply with Android Typogra…
14edda2 
…phy lint rules
@maxme
Make sure the file gutenberg.pot exists before generating android and…
43dabd9 
… ios strings.
Update Gutenberg ref
05b092a
@maxme
Merge pull request #2107 from wordpress-mobile/issue/add-replacements…
be4e87c 
…-to-po2android-script

Add a new androidReplacements function to comply with Android Typography lint rules
@maxme
Merge pull request #2109 from wordpress-mobile/issue/make-sure-requir…
a1be0c4 
…ed-file-exists-before-generating-app-strings

Make sure the file gutenberg.pot exists before generating android and ios strings.
@SergioEstevao
Merge branch 'master' into release/update_develop_with_1.25.0_master
ddc7a4b 
# Conflicts:
#	gutenberg
@SergioEstevao
Merge pull request #2112 from wordpress-mobile/release/update_develop…
c05d991 
…_with_1.25.0_master

Release/update develop with 1.25.0 master
@mkevins mkevins mentioned this pull request Apr 27, 2020
Merged
18 tasks
@mkevins mkevins self-assigned this Apr 27, 2020
@mkevins mkevins mentioned this pull request Apr 27, 2020
Merged
18 tasks
@mkevins mkevins changed the base branch from master to develop April 27, 2020 08:13
@mkevins mkevins changed the base branch from develop to master April 27, 2020 08:13
@mkevins mkevins marked this pull request as ready for review April 27, 2020 10:17
@dratwas
Copy link
Contributor

dratwas commented Apr 27, 2020 •
edited
Loading

Tested on Android:

Gallery-1

  • Gallery block - Close/Re-open post with an ongoing image upload - steps
  • Gallery block - Close post with an ongoing image upload - steps

Gallery-2

  • Gallery block - Insert image from device (failing) - steps
  • Gallery block - Insert image from device (cancel) - steps

Gallery-3

  • Gallery block - Add Gallery Caption - steps
  • Gallery block - Add Gallery Image Caption - steps
  • Gallery block - Try adding same images from WP Media library and moving the images around - steps

Gallery-4

  • Gallery block - Settings: Link to - steps
  • Gallery block - Settings: Column number - steps
  • Gallery block - Settings: Crop images - steps

Columns - 1

  • Columns - Columns block is added with default number of Column - steps
  • Columns - Adding Column with AppenderButton- steps
  • Columns - Adding and removing Column with BottomSheet Stepper control - steps
  • Columns - Max limit of Column number - steps
  • Columns - Min limit of Column number - steps
  • Columns - Removing Column with remove button - steps
  • Columns - Removing the only one left Column with remove button - steps
  • Columns - Changing alignment on Columns - steps
  • Columns - Changing alignment on individual Columnn - steps
  • Columns - Alignment attribute is properly passed when adding Column - steps
  • Columns - Deep nesting is possible (iOS only)- steps

@pinarol
Copy link
Contributor

pinarol commented Apr 28, 2020 •
edited
Loading

Testing on WPiOS:

DarkMode-1

  • Gallery block - Dark mode - steps
  • Shortcode block - Dark mode - steps
  • Media Text block - Dark mode - steps

DarkMode-2

  • Spacer block - Dark mode - steps
  • Button block - Dark mode - steps
  • Group - Dark mode - steps
  • Columns - Dark mode - steps

Group-1

  • Group - AppenderButton is rendered - steps
  • Group - Deep nesting is possible (iOS only) - steps
  • Group - Check if Group placeholder is visible for the unselected state - steps
  • Group - Check if Group placeholder is render in nested structure - steps
  • Group - Nested block have proper border styling - steps
  • Group - Nested block have proper margins values - steps
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - steps
  • Group - Navigation up button works as expected - steps
  • Group - Navigation down works according to parent-first approach - steps
  • Group - Cross navigation between blocks works as expected - steps
  • Group - Ungroup button works as expected - steps
  • Group - Check if in DarkMode all components gets proper colors - steps
  • Group - Check if nested Placeholder block can be replaced - steps

Cover-1

  • Cover - Add image background from WordPress Media library - steps
  • Cover - Change Minimum height in pixels - steps
  • Cover - Change Background Opacity - steps
  • Cover - Image focal point is rendered properly - steps
  • Cover - Custom color is rendered properly - steps

Spacer-1

  • Spacer block - Spacer is rendered without crash - steps
  • Spacer block - Settings: Control spacer height using the slider - steps
  • Spacer block - Settings: Control spacer height using the text input - steps
  • Spacer block - Settings: Available height range is correct - steps
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - steps
  • Spacer block - Spacer in horizontal layout works as expected - steps

@geriux geriux self-requested a review April 29, 2020 12:38
geriux
geriux approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkevins mkevins merged commit bffe9d2 into master Apr 30, 2020
@mkevins
Copy link
Contributor Author

mkevins commented Apr 30, 2020

Thanks for testing!

@mkevins mkevins deleted the release/1.27.0 branch April 30, 2020 08:04
@geriux geriux mentioned this pull request May 6, 2020
Merged
4 tasks
@mchowning mchowning mentioned this pull request May 11, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees

@mkevins mkevins

Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.