Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Fixed position of FloatingToolbar on the bottom of the screen #2118

Merged
merged 28 commits into from
Apr 22, 2020
Merged

Refactor: Fixed position of FloatingToolbar on the bottom of the screen #2118

merged 28 commits into from
Apr 22, 2020

Conversation

jbinda
Copy link
Contributor

@jbinda jbinda commented Apr 7, 2020 •
edited
Loading

Fixes #1414

This PR changes behaviour of FloatingToolbar to align with guideline from this issue. It will be positioning absolutely at the bottom of the screen.

Please also refer to:
Related gutenberg PR
Related gutenberg-mobile issue

To test:

  • check if modified FloatingToolbar is rendered on bottom of the screen on iOS
  • check if modified FloatingToolbar is rendered on top of the screen on Android
  • check if Navigate-Up button in FloatingToolbar is clickable

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jbinda jbinda added [Status] Needs Design Review Needs design review or sign-off before shipping InnerBlocks labels Apr 7, 2020
@jbinda jbinda requested review from pinarol and dratwas April 7, 2020 07:18
@jbinda jbinda self-assigned this Apr 7, 2020
@jbinda jbinda mentioned this pull request Apr 9, 2020
Merged
6 tasks
jbinda added 16 commits April 14, 2020 15:12
@cameronvoell cameronvoell self-requested a review April 21, 2020 23:35
cameronvoell
cameronvoell approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via - WordPress/gutenberg#21446

@jbinda jbinda merged commit 8acfb12 into develop Apr 22, 2020
pinarol
pinarol reviewed Apr 22, 2020
View reviewed changes
RELEASE-NOTES.txt
@@ -3,6 +3,10 @@
* Prefill caption for image blocks when available on the Media library
* New block: Buttons. From now you’ll be able to add the individual Button block only inside the Buttons block
* [iOS]: Video in video blocks can now be played inline on the editor.
* [iOS]: Move FloatingToolbar for nested blocks to appears of the bottom of the screen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes... 🤦 I have prepared fix here

@pinarol pinarol deleted the callstack/feat/fixed-floating-toolbar-position branch April 22, 2020 11:08
This was referenced Apr 27, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol left review comments

@cameronvoell cameronvoell cameronvoell approved these changes

@dratwas dratwas Awaiting requested review from dratwas

Assignees

@jbinda jbinda

Labels
InnerBlocks [Status] Needs Design Review Needs design review or sign-off before shipping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FloatingToolbar ideal version
3 participants
@jbinda @cameronvoell @pinarol