Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: update to v1.27.0 #14002

Merged
merged 7 commits into from
Apr 30, 2020
Merged

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Apr 27, 2020

Related PRs

gutenberg-mobile: wordpress-mobile/gutenberg-mobile#2186
WordPress-Android: wordpress-mobile/WordPress-Android#11756

To test:

Bug fix

New feature & Improvement

Note: including this to ensure we don't see the block in production yet:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mkevins mkevins added this to the 14.8 milestone Apr 27, 2020
@mkevins mkevins self-assigned this Apr 27, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 27, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@mkevins mkevins added the Gutenberg Editing and display of Gutenberg blocks. label Apr 27, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 27, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@mkevins mkevins marked this pull request as ready for review April 27, 2020 10:17
@mkevins mkevins requested a review from geriux April 27, 2020 10:17
@geriux
Copy link
Contributor

geriux commented Apr 27, 2020

Writing flow sanity check

@geriux
Copy link
Contributor

geriux commented Apr 27, 2020

Related PRs and Writing flow sanity check tests ✅

@mkevins
Copy link
Contributor Author

mkevins commented Apr 28, 2020

Cover-1 ✔️

  • Cover - Add image background from WordPress Media library - steps
  • Cover - Change Minimum height in pixels - steps
  • Cover - Change Background Opacity - steps
  • Cover - Image focal point is rendered properly - steps
  • Cover - Custom color is rendered properly - steps

Button-1 ✔️

  • Button block - Render custom text color - steps
  • Button block - Render custom background color - steps
  • Button block - Render gradient background color - steps
  • Button block - Check if selection / caret color matches font color - steps

Button-2 ✔️

  • Button block - Edit text styles - steps
  • Button block - Fallback to default colors in case theme colors are used - steps
  • Button block - New Button is created with the gray color - steps
  • Button block - Settings: Change Button border radius - steps
  • Button block - The newly created button has set background color to the theme-default color in preview - steps
  • Button block - Tapping delete key removes block when Button is empty - steps

Button-3 ✔️

Note: These tests could be improved by displaying the image for which "settings button" to press directly in the test steps (rather than linking to the image). At first, I conducted the tests using the block settings, instead of the RichText settings, until I realized intention was to first use the RichText settings button.

  • Button block - Settings: Open in new tab - steps
  • Button block - Settings: Link rel - steps
  • Button block - Settings: Link URL - steps
  • Button block - Settings: Remove link - steps
  • Button block - Settings: Synchronize with button options - steps

Button-4 ❓

  • Button block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - steps
  • Button block - Toolbar link button is active when Button has link - steps
  • Button block - Button max width is calculated OK inside inner blocks(iOS only) - steps

All tests pass, but strange behavior / bug observed for button inside group block. For some reason, when I add a button inside a group block, it doesn't show changes in the preview that appear after the button.

Screencast - Preview doesn't show new content after button inside group

@lukewalczak
Copy link
Contributor

@mkevins I was not able to reproduce that problem, however, I was checking it on the simulator using release branch, because looks like .ipa expired.

Steps I went through:

  1. Open a post
  2. Add Group block
  3. Add Paragraph into Group block
  4. Type Test
  5. Open a preview - check if the paragraph is displayed correctly
  6. Add Buttons into Group block
  7. Type Test
  8. Open a preview - check if the button is displayed correctly
  9. Add another Buttons into Group block
  10. Type Test
  11. Open a preview - check if the button is displayed correctly

Output:

Kapture 2020-04-29 at 10 04 21

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! We just need to change the commit for the tag.

@mkevins mkevins merged commit 13d700b into develop Apr 30, 2020
@mkevins
Copy link
Contributor Author

mkevins commented Apr 30, 2020

Thanks for testing!

@mkevins mkevins deleted the gutenberg/integrate_release_1.27.0 branch April 30, 2020 08:04
@mkevins
Copy link
Contributor Author

mkevins commented May 1, 2020

@mkevins I was not able to reproduce that problem, however, I was checking it on the simulator using release branch, because looks like .ipa expired.

Thanks for attempting to reproduce this @lukewalczak ! I have confirmed this bug does not require the group block. Also, I have confirmed that it does not appear to be related with button(s) block, which is where I originally encountered the issue while testing. This may be an issue with preview. I have now encountered this with the following steps:

  1. Add a new post
  2. Repeat the following 3 times:
    1. Add a paragraph with some text
    2. View preview (obvserve the new paragraph is display in the preview)
    3. Switch back to editing

On the third edit, I observed that the preview content was "stale". I'll open an issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants