-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Aztec-Android for alignment handling #2006
Conversation
We're freezing |
@mchowning I still have hopes that you can have this available on 1.25, but if not please move it to the 1.26 milestone. |
I am changing the milestone of this PR as 1.27 because the 1.26 release branch will be cut quite soon. Let me know if you instead wanted to include this to 1.26. |
719b019
to
6ac77c6
Compare
6ac77c6
to
174dac2
Compare
...native-aztec/android/src/main/java/org/wordpress/mobile/ReactNativeAztec/ReactAztecText.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good code-wise! I still haven't made a pass to test the behavior but I'll LGTM this and someone (or me) can do the testing pass.
aabf1ce
to
90dd372
Compare
90dd372
to
c17064c
Compare
Description
Enables alignment on Android for non
<p>
-based blocks. In particular,aztecVersion
in this PR must be updated before this is merged.Related PRs
wordpress-mobile/AztecEditor-Android#899
WordPress/gutenberg#21803
wordpress-mobile/WordPress-Android#11752
Testing
These tests should all be performed on both iOS and Android.
Heading, Verse, and Quote Blocks
[Heading, Verse, Quote].forEach { block ->
block
^}
Pullquote Block
Regressions
Verify that:
PR submission checklist
RELEASE-NOTES.txt
if necessary.