Cover block uploads failure UI #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2020
geriux
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
Approved via WordPress/gutenberg#21198 (review)
As I mentioned, code and functionality are approved but there's still pending a design/UX approval.
This was referenced Apr 15, 2020
|
Thanks for reviewing and testing Gerardo! |
This was referenced Apr 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds UI for failed uploads in the Cover block, and also allows cancellation of ongoing uploads.
Related PRs
gutenberg: [Mobile] Cover block uploads failure UI WordPress/gutenberg#21198Testing steps
Testing steps provided in related
gutenbergPR.PR submission checklist:
RELEASE-NOTES.txtif necessary.