-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Cover with in Cover support #13928
[RNMobile] Cover with in Cover support #13928
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
…-uploads-nested-blocks
…-uploads-nested-blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Chip 👋 😃 I tested this via the description, and it works as described. Also, I ran all unit tests, and everything is passing, and there is good test coverage for many nested cases 👍 .
I'll defer to @SergioEstevao for the code review, since he is very familiar with this area of the code, but the solution generally looks reasonable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great!
Special Thanks for the updates on the Gutenberg block processor! We now are future proof for blocks inside blocks!
Fixes: wordpress-mobile/gutenberg-mobile#1739
Description
This PR implements the Cover block within a Cover Block for image uploads. Building off of #13909
This also modifies block parser for Image, Gallery, Media-Text, and Video blocks. (This was done in a separate commit so can be reverted to just Cover block if needed)
Related PRs:
WordPress-iOS parent PR:
Rnmobile/cover block uploads #13909gutenberg:
[Mobile] Cover block uploads failure UI WordPress/gutenberg#21198gutenberg-mobile
: Cover block uploads failure UI gutenberg-mobile#2150To Test for Cover Block:
To Test for other blocks:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.