Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new androidReplacements function to comply with Android Typography lint rules #2107

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

maxme
Copy link
Contributor

@maxme maxme commented Apr 3, 2020

Add a new androidReplacements function to comply with Android Typography lint rules

@maxme maxme requested a review from Tug April 3, 2020 13:12
@Tug
Copy link
Contributor

Tug commented Apr 3, 2020

Change looks good 👍 , anything else I should be looking at for the review?

@maxme
Copy link
Contributor Author

maxme commented Apr 3, 2020

anything else I should be looking at for the review?

This can be tested with current gutenberg-mobile develop, before the patch, the following commands will result in a lint error (see this wordpress-mobile/WordPress-Android#11585 (comment)), after the patch the same commands will work fine.

cd libs/gutenberg-mobile
yarn genstrings
cd ../..
python tools/merge_strings_xml.py
./gradlew :WordPress:lintVanillaRelease

@Tug
Copy link
Contributor

Tug commented Apr 3, 2020

Don't you mean gutenberg-mobile master? On develop, yarn genstrings is failing because of a tsconfig issue in gutenberg.

Edit: If I update gutenberg to master, which has this fix from @SergioEstevao yarn genstrings works

Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took a while to run that last command (twice) but it indeed fixes the aforementioned issue :)

🚢

@maxme
Copy link
Contributor Author

maxme commented Apr 3, 2020

yarn genstrings is failing because of a tsconfig issue in gutenberg.

Yes, sorry I forgot about that, I had to apply the patch from WordPress/gutenberg#21324

Thanks for reviewing it!

@maxme maxme merged commit be4e87c into develop Apr 3, 2020
@maxme maxme deleted the issue/add-replacements-to-po2android-script branch April 3, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants