Make sure the file gutenberg.pot exists before generating android and ios strings. #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxme
deleted the
issue/make-sure-required-file-exists-before-generating-app-strings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wp i18n make-potscripts doesn't stop when the referenced filegutenberg.potin the--subtractparameter is missing. There is a warning shown, but it get lost in other console lines.If this file is missing, the generated string file will contains all the gutenberg text entry, even those that are not needed in the app.
And this file can be missing if the build failed or if the command
makepot:androidormakepot:iosare called directly.This patch just test
gutenberg.potexists before running the actual command.