Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.26.0 #2153

Merged
merged 63 commits into from
Apr 16, 2020
Merged

Release v1.26.0 #2153

merged 63 commits into from
Apr 16, 2020

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Apr 13, 2020 •
edited
Loading

Release for Gutenberg Mobile v1.26.0

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

FULL LIST

Bug fix

New feature & Improvement

Test plan

  • Use the main WP apps to test the changes above.
  • Check WPAndroid and WPiOS PRs if there are specific tests to run.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Release number was bumped
  • Aztec dependencies are pointing to a stable release
    • iOS: 'grep WordPressAztec-iOS RNTAztecView.podspec'
    • Android: 'grep aztecVersion react-native-aztec/android/build.gradle'
  • Gutenberg 'Podfile' and 'Podfile.lock' inside './ios/' are updated to the release number
  • Bundle package of the release is updated
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release

chipsnyder and others added 30 commits March 24, 2020 15:07
@chipsnyder
Add tests for Latest-Posts Bock
2a16c92
@chipsnyder
Have the Automation tests Scroll the Block window to help locate Bloc…
deee22c 
…k buttons on Android
@mkevins
Update gutenberg reference
ff15683
@mkevins
Merge branch 'develop' into feature/cover-block-uploads-enable-dev-on…
45ddf0b 
…ly-and-progress
Update Gutenberg ref
6ae0d7c
Merge with develop
07b5cf1
Update Gutenberg ref
362e01a
Merge with develop
c76396d
@SergioEstevao
New template for release PRs
e368e0c 
This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md`
@SergioEstevao
Update template file.
0d6fed4
@jbinda
Fix: remove extra padding for post title and first Paragraph block (#…
57eb178 
…2095)

* Fix: remove extra padding for post title and first `Paragraph` block
Merge pull request #2060 from wordpress-mobile/rnmobile/latest-post-t…
6ff600a 
…ests

Add tests for Latest-Posts Bock
Update Gutenberg ref
1fb1976
@maxme
Add a new androidReplacements function to comply with Android Typogra…
14edda2 
…phy lint rules
@maxme
Make sure the file gutenberg.pot exists before generating android and…
43dabd9 
… ios strings.
Update Gutenberg ref
05b092a
@maxme
Merge pull request #2107 from wordpress-mobile/issue/add-replacements…
be4e87c 
…-to-po2android-script

Add a new androidReplacements function to comply with Android Typography lint rules
@maxme
Merge pull request #2109 from wordpress-mobile/issue/make-sure-requir…
a1be0c4 
…ed-file-exists-before-generating-app-strings

Make sure the file gutenberg.pot exists before generating android and ios strings.
@SergioEstevao
Merge branch 'master' into release/update_develop_with_1.25.0_master
ddc7a4b 
# Conflicts:
#	gutenberg
@SergioEstevao
Merge pull request #2112 from wordpress-mobile/release/update_develop…
c05d991 
…_with_1.25.0_master

Release/update develop with 1.25.0 master
@Tug
Update gutenberg ref
d8e0061
@Tug
Update gutenberg ref
57355a1
@Tug
Merge pull request #2113 from wordpress-mobile/fix/target-gutenberg-m…
7898f98 
…aster

Create a stable version of @wordpress/interface components for mobile
@mkevins
Update gutenberg reference
e33540d
@mkevins
Merge branch 'develop' into feature/cover-block-uploads-enable-dev-on…
680dc91 
…ly-and-progress
@chipsnyder
Gutenberg update
c2a55b6
Update Gutenberg ref
111e79d
Merge branch 'develop' into fix/layout-preview-modal
eff00be
Merge pull request #2086 from wordpress-mobile/fix/layout-preview-modal
230319c 
Layout Template Modal & Button block - Orientation fixes
Update Gutenberg ref
eb103cb
@pinarol pinarol mentioned this pull request Apr 13, 2020
Merged
12 tasks
@pinarol pinarol mentioned this pull request Apr 13, 2020
Merged
12 tasks
@pinarol
Copy link
Contributor Author

pinarol commented Apr 13, 2020

ipa/apk is ready to test on the main apps.

@pinarol pinarol self-assigned this Apr 13, 2020
@jbinda
Copy link
Contributor

jbinda commented Apr 14, 2020 •
edited
Loading

iOS TESTS

MediaText-1

  • Media Text block - Insert image from device (failing) - steps
  • Media Text block - Close/Re-open post with an ongoing image upload - steps

MediaText-2

  • Media Text block - Insert video from device (cancel) - steps
  • Media Text block - Insert image from device (cancel) - steps

MediaText-3

  • Media Text block - Insert video from device (failing) - steps
  • Media Text block - Close/Re-open post with an ongoing video upload - steps

MediaText-4

  • Media Text block - Media & Text alignment - steps
  • Media Text block - Vertical alignment - steps

MultipleUpload-1

  • Simultaneous uploads - steps

Shortcode-1

  • Shortcode block - Add a youtube link - steps

Cover-2

  • Cover - Add Video Background from WordPress Media library - steps
  • Cover - Replace media - steps
  • Cover - Gradient background is rendered properly - steps
  • Cover - Gradient overlay is rendered properly - steps

Columns - 2

  • Columns - Check if Column placeholders is visible for the unselected state - steps
  • Columns - Appearance in vertical device position (vertical layout) - steps
  • Columns - Appearance in horizontal device position (horizontal layout) - steps
  • Columns - Mover direction - steps
  • Columns - Check if Column placeholder is render in nested structure - steps
  • Columns - Unselected Column placeholder is streched to content in nested structure- steps

Columns - 3

  • Columns - Check if in DarkMode all components gets proper colors (iOS) - steps

Testes with above on iOS and didn't noticed any unexpected behaviour

@geriux
Copy link
Contributor

geriux commented Apr 14, 2020 •
edited
Loading

Android Sanity tests

DarkMode-1

  • Gallery block - Dark mode - steps
  • Shortcode block - Dark mode - steps
  • Media Text block - Dark mode - steps

DarkMode-2

  • Spacer block - Dark mode - steps
  • Button block - Dark mode - steps
  • Group - Dark mode - steps
  • Columns - Dark mode - steps

Group-1

  • Group - AppenderButton is rendered - steps
  • Group - Check if Group placeholder is visible for the unselected state - steps
  • Group - Check if Group placeholder is render in nested structure - steps
  • Group - Nested block have proper border styling - steps
  • Group - Nested block have proper margins values - steps
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - steps
  • Group - Navigation up button works as expected - steps
  • Group - Navigation down works according to parent-first approach - steps
  • Group - Cross navigation between blocks works as expected - steps
  • Group - Ungroup button works as expected - steps
  • Group - Check if in DarkMode all components gets proper colors - steps
  • Group - Check if nested Placeholder block can be replaced - steps

Spacer-1

  • Spacer block - Spacer is rendered without crash - steps
  • Spacer block - Settings: Control spacer height using the slider - steps
  • Spacer block - Settings: Control spacer height using the text input - steps
  • Spacer block - Settings: Available height range is correct - steps
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - steps
  • Spacer block - Spacer in horizontal layout works as expected - steps

@lukewalczak
Copy link
Contributor

lukewalczak commented Apr 14, 2020 •
edited
Loading

iOS Sanity tests

Gallery-1

  • Gallery block - Close/Re-open post with an ongoing image upload - steps ✅
  • Gallery block - Close post with an ongoing image upload - steps ✅

Gallery-2

  • Gallery block - Insert image from device (failing) - steps ✅
  • Gallery block - Insert image from device (cancel) - steps ✅

Gallery-3

  • Gallery block - Add Gallery Caption - steps ✅
    🔈 I've noticed there is no option for underline, instead of it there is a strikethrough option.
  • Gallery block - Add Gallery Image Caption - steps ✅
  • Gallery block - Try adding same images from WP Media library and moving the images around - steps ✅

Gallery-4
🔈 - Missing steps for these test cases, however, I've tested it
intuitively two test case except Link To

  • Gallery block - Settings: Link to - steps
  • Gallery block - Settings: Column number - steps ✅
  • Gallery block - Settings: Crop images - steps ✅

Columns - 1

  • Columns - Columns block is added with default number of Column - steps ✅
  • Columns - Adding Column with AppenderButton- steps ✅
  • Columns - Adding and removing Column with BottomSheet Stepper control - steps ✅
  • Columns - Max limit of Column number - steps ✅
  • Columns - Min limit of Column number - steps ✅
  • Columns - Removing Column with remove button - steps ✅
  • Columns - Removing the only one left Column with remove button - steps ✅
  • Columns - Changing alignment on Columns - steps ✅
  • Columns - Changing alignment on individual Columnn - steps ✅
  • Columns - Alignment attribute is properly passed when adding Column - steps ✅
  • Columns - Deep nesting is possible (iOS only)- steps ✅

@pinarol
Copy link
Contributor Author

pinarol commented Apr 14, 2020 •
edited
Loading

🔈 I've noticed there is no option for underline, instead of it there is a strikethrough option.

@lukewalczak I confirmed that this is normal, it turns out we didn't have Underline option anyway. Updated the test steps.

@pinarol
Copy link
Contributor Author

pinarol commented Apr 14, 2020

@mkevins it would be really good if you could add steps to Gallery-4 items, it looks like they are not very intuitive.

@pinarol
Copy link
Contributor Author

pinarol commented Apr 15, 2020

Re-generated ipa/apk on parent apps after including the fix:
Correct colors usage in Button

@chipsnyder
Copy link
Contributor

chipsnyder commented Apr 15, 2020 •
edited
Loading

Android Sanity tests

Button-1

Button-2

  • Button block - Edit text styles - steps
  • Button block - Fallback to default colors in case theme colors are used - steps
  • Button block - New Button is created with the gray color - steps
  • Button block - Settings: Change Button border radius - steps
  • Button block - The newly created button has set background color to the theme-default color in preview - steps
  • Button block - Tapping delete key removes block when Button is empty - steps

Button-3

  • Button block - Settings: Open in new tab - steps
  • Button block - Settings: Link rel - steps
  • Button block - Settings: Link URL - steps
  • Button block - Settings: Remove link - steps
  • Button block - Settings: Synchronize with button options - steps

Button-4

  • Button block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - steps
  • Button block - Toolbar link button is active when Button has link - steps

Cover-1

  • Cover - Add image background from WordPress Media library - steps
  • Cover - Change Minimum height in pixels - steps
  • Cover - Change Background Opacity - steps
  • Cover - Image focal point is rendered properly - steps
  • Cover - Custom color is rendered properly - steps

Discovered Issues:

#2158

@chipsnyder
Copy link
Contributor

@pinarol I found a conversion error for button blocks #2158. I didn't dive into the history for this yet though to see if this something that should be a bug in Gutenberg or Gutenberg-Mobile. It looks like adding buttons on the web though wraps them in a "buttons" block which I think callstack is working on iirc.

@lukewalczak
Copy link
Contributor

Hey @chipsnyder I forgot to mention about it. I went through the files history and noticed that some days ago web Button block was refactored and e.g div wrapper was removed from save function.

When I run locally the latest gutenberg version it works as expected so unfortunatelly we've faced the situation where older version of gutenberg editor is trying to edit the block generated by a newer version.

You can read more about it on slack discussion

@chipsnyder
Copy link
Contributor

chipsnyder commented Apr 15, 2020 •
edited
Loading

Thanks @lukewalczak, I did miss that conversation. What you described is exactly the case that's happening. I'll close that ticket with this description.

@chipsnyder chipsnyder mentioned this pull request Apr 15, 2020
Closed
@pinarol
Copy link
Contributor Author

pinarol commented Apr 16, 2020

When I run locally the latest gutenberg version it works as expected so unfortunatelly we've faced the situation where older version of gutenberg editor is trying to edit the block generated by a newer version.

That's it. Unfortunately currently there's no technical solution for that. Luckily release cycles of web and mobile is close.

@pinarol
Copy link
Contributor Author

pinarol commented Apr 16, 2020

I checked this one by checking the output links in the browser, seems fine:

  • Gallery block - Settings: Link to - steps

geriux
geriux approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pinarol
Copy link
Contributor Author

pinarol commented Apr 16, 2020

Merging the release. Thank you everyone! @etoledom @chipsnyder @lukewalczak @jbinda

@pinarol pinarol merged commit 315a213 into master Apr 16, 2020
pinarol added a commit that referenced this pull request Apr 16, 2020
@pinarol @chipsnyder
@mkevins @SergioEstevao @jbinda @maxme @Tug @khaykov @lukewalczak
Update develop with master v1.26.0 (#2164)
c6e5be9 
* Release v1.26.0 (#2153)

* Add tests for Latest-Posts Bock

* Have the Automation tests Scroll the Block window to help locate Block buttons on Android

* Update gutenberg reference

* Update Gutenberg ref

* Update Gutenberg ref

* New template for release PRs

This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md`

* Update template file.

* Fix: remove extra padding for post title and first `Paragraph` block (#2095)

* Fix: remove extra padding for post title and first `Paragraph` block

* Update Gutenberg ref

* Add a new androidReplacements function to comply with Android Typography lint rules

* Make sure the file gutenberg.pot exists before generating android and ios strings.

* Update Gutenberg ref

* Update gutenberg ref

* Update gutenberg ref

* Update gutenberg reference

* Gutenberg update

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Fix: prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS (#2023)

* prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS

* Update Gutenberg ref

* Update Gutenberg ref

* Accept multiple headers through OnAuthHeaderRequestedListener (#2080)

* Blog layout template (#2114)

* Update Gutenberg ref

* Update Gutenberg ref

* Update gutenberg reference

* Fix failing UI tests

Try scrolling in the Inserter for all platforms

* Disable the failing test on iOS

Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Pinar Olguc <[email protected]>

* Update gutenberg reference

* Feat: Column block (#1661)

* update ref to master (Columns Block)

* Update gutenberg reference

* Fix Latests Posts Tests by expanding the scroll to button functionality

* Fix lint issue

* Fix typography breakage in master

To a version where the typography panel is not added to block settings.

* Update GB reference.

* Correct slider step value (#2119)

* Update ref: Correct slider step accordingly to the platform

* Update gb ref

Co-authored-by: Pinar Olguc <[email protected]>

* v1.26.0

* Add some missing release notes

* Update Podfile.lock

* Update gb ref

* Update bundles

Co-authored-by: Chip Snyder <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Sérgio Estêvão <[email protected]>
Co-authored-by: jbinda <[email protected]>
Co-authored-by: Chip <[email protected]>
Co-authored-by: Maxime Biais <[email protected]>
Co-authored-by: Tugdual de Kerviler <[email protected]>
Co-authored-by: Klymentiy Haykov <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Luke Walczak <[email protected]>

* Update gb ref

Co-authored-by: Chip Snyder <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Sérgio Estêvão <[email protected]>
Co-authored-by: jbinda <[email protected]>
Co-authored-by: Chip <[email protected]>
Co-authored-by: Maxime Biais <[email protected]>
Co-authored-by: Tugdual de Kerviler <[email protected]>
Co-authored-by: Klymentiy Haykov <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Luke Walczak <[email protected]>
@dcalhoun dcalhoun deleted the release/1.26.0 branch August 28, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

@chipsnyder chipsnyder Awaiting requested review from chipsnyder

@jbinda jbinda Awaiting requested review from jbinda

@lukewalczak lukewalczak Awaiting requested review from lukewalczak

Assignees

@pinarol pinarol

Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@pinarol @jbinda @geriux @lukewalczak @chipsnyder @mkevins @SergioEstevao @maxme @Tug @khaykov