Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg: update to v1.26.0 #11647

Merged
merged 9 commits into from
Apr 16, 2020
Merged

Gutenberg: update to v1.26.0 #11647

merged 9 commits into from
Apr 16, 2020

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Apr 13, 2020 •
edited by geriux
Loading

gutenberg-mobile: wordpress-mobile/gutenberg-mobile#2153
WPiOS: wordpress-mobile/WordPress-iOS#13878

To test:

Bug fix

New feature & Improvement

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 13, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@pinarol pinarol added the Gutenberg Editing and display of Gutenberg blocks. label Apr 13, 2020
@pinarol pinarol mentioned this pull request Apr 13, 2020
Merged
6 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 13, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@pinarol pinarol mentioned this pull request Apr 13, 2020
Merged
12 tasks
@pinarol pinarol added this to the 14.7 milestone Apr 13, 2020
@pinarol
Copy link
Contributor Author

pinarol commented Apr 13, 2020 •
edited by geriux
Loading

Writing flow sanity check:

  • Undo-redo (steps)
  • Copy-paste (steps)
  • Splitting blocks (steps)
  • Multiline components (steps)
    ⚠️ Verse and Code are under the dev flag so they can't be tested
  • Formatting on rich-text based components (steps)
    ⚠️ After this bug was reported I double checked and it happens on android as well.
  • Block insertion (steps)

@pinarol pinarol requested a review from geriux April 13, 2020 17:11
@pinarol pinarol self-assigned this Apr 13, 2020
@geriux
Copy link
Contributor

geriux commented Apr 14, 2020

All tests done! ✅

@geriux
Copy link
Contributor

geriux commented Apr 14, 2020

FYI the gutenberg-mobile ref is behind one commit (Podfile lock update)

@geriux
Copy link
Contributor

geriux commented Apr 15, 2020

Tested the new build with:

@pinarol pinarol merged commit 03da46e into develop Apr 16, 2020
@pinarol pinarol deleted the gutenberg/integrate_release_1.26.0 branch April 16, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees

@pinarol pinarol

Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
14.7
Development

Successfully merging this pull request may close these issues.
2 participants
@pinarol @geriux