Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Column block #1661

Merged
merged 170 commits into from
Apr 9, 2020
Merged

Feat: Column block #1661

merged 170 commits into from
Apr 9, 2020

Conversation

jbinda
Copy link
Contributor

@jbinda jbinda commented Dec 9, 2019

Fixes #1430

Please also refer to:
Merge it first gutenberg-mobile PR:
Navigation-Down feature
Fix: Group Appender

Related gutenberg PR
Related gutenberg-mobile issue

It presents:
Ability to add Columns Block

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 8, 2020

You can trigger optional full suite of UI tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional full suite of UI tests for these changes by visiting CircleCI here.

Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the gutenberg PR 🎉

@pinarol
Copy link
Contributor

pinarol commented Apr 8, 2020

Now that we removed DEV flag, don't forget to add RELEASE NOTES :) @jbinda

@jbinda
Copy link
Contributor Author

jbinda commented Apr 8, 2020

sure ! I will update when updating the submodule reference to gutenberg repo

@jbinda jbinda merged commit ae8999f into develop Apr 9, 2020
@jbinda
Copy link
Contributor Author

jbinda commented Apr 9, 2020

merged ! 🎉

@pinarol pinarol deleted the callstack/column-block branch April 9, 2020 19:57
@pinarol pinarol added this to the 1.26 milestone Apr 13, 2020
pinarol added a commit that referenced this pull request Apr 16, 2020
* Add tests for Latest-Posts Bock

* Have the Automation tests Scroll the Block window to help locate Block buttons on Android

* Update gutenberg reference

* Update Gutenberg ref

* Update Gutenberg ref

* New template for release PRs

This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md`

* Update template file.

* Fix: remove extra padding for post title and first `Paragraph` block (#2095)

* Fix: remove extra padding for post title and first `Paragraph` block

* Update Gutenberg ref

* Add a new androidReplacements function to comply with Android Typography lint rules

* Make sure the file gutenberg.pot exists before generating android and ios strings.

* Update Gutenberg ref

* Update gutenberg ref

* Update gutenberg ref

* Update gutenberg reference

* Gutenberg update

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Fix: prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS (#2023)

* prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS

* Update Gutenberg ref

* Update Gutenberg ref

* Accept multiple headers through OnAuthHeaderRequestedListener (#2080)

* Blog layout template (#2114)

* Update Gutenberg ref

* Update Gutenberg ref

* Update gutenberg reference

* Fix failing UI tests

Try scrolling in the Inserter for all platforms

* Disable the failing test on iOS

Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Pinar Olguc <[email protected]>

* Update gutenberg reference

* Feat: Column block (#1661)

* update ref to master (Columns Block)

* Update gutenberg reference

* Fix Latests Posts Tests by expanding the scroll to button functionality

* Fix lint issue

* Fix typography breakage in master

To a version where the typography panel is not added to block settings.

* Update GB reference.

* Correct slider step value (#2119)

* Update ref: Correct slider step accordingly to the platform

* Update gb ref

Co-authored-by: Pinar Olguc <[email protected]>

* v1.26.0

* Add some missing release notes

* Update Podfile.lock

* Update gb ref

* Update bundles

Co-authored-by: Chip Snyder <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Sérgio Estêvão <[email protected]>
Co-authored-by: jbinda <[email protected]>
Co-authored-by: Chip <[email protected]>
Co-authored-by: Maxime Biais <[email protected]>
Co-authored-by: Tugdual de Kerviler <[email protected]>
Co-authored-by: Klymentiy Haykov <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Luke Walczak <[email protected]>
pinarol added a commit that referenced this pull request Apr 16, 2020
* Release v1.26.0 (#2153)

* Add tests for Latest-Posts Bock

* Have the Automation tests Scroll the Block window to help locate Block buttons on Android

* Update gutenberg reference

* Update Gutenberg ref

* Update Gutenberg ref

* New template for release PRs

This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md`

* Update template file.

* Fix: remove extra padding for post title and first `Paragraph` block (#2095)

* Fix: remove extra padding for post title and first `Paragraph` block

* Update Gutenberg ref

* Add a new androidReplacements function to comply with Android Typography lint rules

* Make sure the file gutenberg.pot exists before generating android and ios strings.

* Update Gutenberg ref

* Update gutenberg ref

* Update gutenberg ref

* Update gutenberg reference

* Gutenberg update

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Fix: prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS (#2023)

* prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS

* Update Gutenberg ref

* Update Gutenberg ref

* Accept multiple headers through OnAuthHeaderRequestedListener (#2080)

* Blog layout template (#2114)

* Update Gutenberg ref

* Update Gutenberg ref

* Update gutenberg reference

* Fix failing UI tests

Try scrolling in the Inserter for all platforms

* Disable the failing test on iOS

Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Pinar Olguc <[email protected]>

* Update gutenberg reference

* Feat: Column block (#1661)

* update ref to master (Columns Block)

* Update gutenberg reference

* Fix Latests Posts Tests by expanding the scroll to button functionality

* Fix lint issue

* Fix typography breakage in master

To a version where the typography panel is not added to block settings.

* Update GB reference.

* Correct slider step value (#2119)

* Update ref: Correct slider step accordingly to the platform

* Update gb ref

Co-authored-by: Pinar Olguc <[email protected]>

* v1.26.0

* Add some missing release notes

* Update Podfile.lock

* Update gb ref

* Update bundles

Co-authored-by: Chip Snyder <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Sérgio Estêvão <[email protected]>
Co-authored-by: jbinda <[email protected]>
Co-authored-by: Chip <[email protected]>
Co-authored-by: Maxime Biais <[email protected]>
Co-authored-by: Tugdual de Kerviler <[email protected]>
Co-authored-by: Klymentiy Haykov <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Luke Walczak <[email protected]>

* Update gb ref

Co-authored-by: Chip Snyder <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Sérgio Estêvão <[email protected]>
Co-authored-by: jbinda <[email protected]>
Co-authored-by: Chip <[email protected]>
Co-authored-by: Maxime Biais <[email protected]>
Co-authored-by: Tugdual de Kerviler <[email protected]>
Co-authored-by: Klymentiy Haykov <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Luke Walczak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks [Status] Needs Design Review Needs design review or sign-off before shipping [Status] Not Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Column block - 1st iteration
4 participants