Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Group appender behaviour #1588

Closed
wants to merge 18 commits into from
Closed

Fix: Group appender behaviour #1588

wants to merge 18 commits into from

Conversation

jbinda
Copy link
Contributor

@jbinda jbinda commented Nov 18, 2019 •
edited
Loading

Fixes group appender behaviour

Please also refer to:
Related gutenberg PR

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@jbinda jbinda added the bugfix label Nov 18, 2019
@jbinda jbinda requested review from hypest and pinarol November 18, 2019 09:24
@jbinda jbinda self-assigned this Nov 18, 2019
@jbinda jbinda mentioned this pull request Nov 18, 2019
Merged
6 tasks
@jbinda jbinda mentioned this pull request Dec 9, 2019
Merged
1 task
@lukewalczak lukewalczak force-pushed the callstack/fix-group-appender branch from d54e25e to ac7a3b2 Compare December 12, 2019 13:09
hypest
hypest approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Feel free to update the Gutenberg ref to the merged one when the Gutenberg PR gets merged and then merge this PR too.

I'd probably suggest reverting the bundle and map files to avoid the conflicts anyway.

@pinarol
Copy link
Contributor

pinarol commented Jan 10, 2020

Seems like it this PR is not necessary anymore since the gutenberg ref was updated by other PRs. Closing this.

@pinarol pinarol closed this Jan 10, 2020
@jbinda jbinda deleted the callstack/fix-group-appender branch March 25, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

@pinarol pinarol Awaiting requested review from pinarol

Assignees

@jbinda jbinda

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbinda @pinarol @hypest @dratwas @lukewalczak